delphi: simplify code

Author: NickVolynkin

Delphi/PDFReportGenerator.dpr

@@ -13,27 +13,25 @@ uses
   dxReport,                      // DevExpress Reports frontend
   dxReport.Parameters;
 
-// Export a report to a PDF file in headless mode:
+// Export a report to a PDF file in non-interactive mode:
 // without showing the report in the Report Designer or Report Viewer, or otherwise using UI.
-
-procedure ExportReportToPdf(const ALayout, AOrderID, AOutput: string);
 // Parameters:
-// ALayout: path to the report layout file (.repx), default value: '..\Order.repx'
-// AOrderID: order ID to filter report data, default value: '11077'
-// AOutput: path to the output PDF file, default value: '<ALayout>_<AOrderID>.pdf'
+// AOrderID: order ID to use in report data, for example, '11077'
+procedure ExportReportToPdf(const AOrderID: string);
 var
   AConnection: TdxBackendDatabaseSQLConnection;
   AReport: TdxReport;
   AReportParameter: TdxReportParameter;
   AStream: TMemoryStream;
+  AOutputFileName: string;
 begin
   // Step 1: Create a report instance and load the report layout
   AReport := TdxReport.Create(nil);
   try
     // Set an internal report name (does not affect the exported PDF content and file name)
     AReport.ReportName := 'OrderReport';
     // Load the report layout from the specified file
-    AReport.Layout.LoadFromFile(ALayout);
+    AReport.Layout.LoadFromFile('..\Order.repx');
 
     // Step 2: Create a database connection
     AConnection := TdxBackendDatabaseSQLConnection.Create(nil);
@@ -46,18 +44,17 @@ begin
       // Step 3: Define Report Parameter Values
       AReport.LoadParametersFromReport;
       // Set the value of the "OrderIdParameter" parameter in the report layout
-      for AReportParameter in AReport.Parameters do
-        if AReportParameter.Name = 'OrderIdParameter' then
-          AReportParameter.Value := AOrderID;
+      AReport.Parameters['OrderIdParameter'].Value := AOrderID;
 
       // Step 4: Export a report to PDF
       AStream := TMemoryStream.Create;
       try
         // Export a report to PDF format and save it to a memory stream
         AReport.ExportToPDF(AStream);
         // Write the content of the memory stream to a file
-        AStream.SaveToFile(AOutput);
-        Writeln('Report saved to: ', AOutput);
+        AOutputFileName := '..\Order_' + AOrderID + '.pdf';
+        AStream.SaveToFile(AOutputFileName);
+        Writeln('Report saved to: ', AOutputFileName);
       finally
         AStream.Free;
       end;
@@ -72,30 +69,34 @@ end;
 // The helper application entry point that parses command-line parameters and calls the export procedure
 begin
   var
-    ALayout, AOrderID, AOutput, AParam: string;
+    AOrderID, AParam: string;
+    Key, Value: string;
+    i: Integer;
   try
-    ALayout := '..\Order.repx'; // Default value
-    AOrderID := '11077';        // Default value
+    AOrderID := ''; // Initialize as empty
 
     // Parse command-line parameters in the format "key=value"
-    for var i := 1 to ParamCount do
+    for i := 1 to ParamCount do
     begin
       AParam := ParamStr(i);
       if AParam.Contains('=') then
       begin
-        var Key := Copy(AParam, 1, Pos('=', AParam) - 1).ToLower;
-        var Value := Copy(AParam, Pos('=', AParam) + 1, Length(AParam));
+        Key := Copy(AParam, 1, Pos('=', AParam) - 1).ToLower;
+        Value := Copy(AParam, Pos('=', AParam) + 1, Length(AParam));
 
-        if Key = 'alayout' then
-          ALayout := Value
-        else if Key = 'aorderid' then
+        if Key = 'orderid' then
           AOrderID := Value;
       end;
     end;
 
-    AOutput := ChangeFileExt(ALayout, '') + '_' + AOrderID + '.pdf';
+    // Check if AOrderID is provided
+    if AOrderID.IsEmpty then
+    begin
+      Writeln('Error: OrderID parameter is required. For example: PDFReportGenerator.exe orderid=11077');
+      Halt(1); // Exit with error code 1
+    end;
 
-    ExportReportToPdf(ALayout, AOrderID, AOutput);
+    ExportReportToPdf(AOrderID);
   except
     on E: Exception do
       Writeln(E.ClassName, ': ', E.Message);