Skip to content

Commit ed53b3e

Browse files
Describe suppression reason (#626)
1 parent bacf9cf commit ed53b3e

File tree

6 files changed

+3
-19
lines changed

6 files changed

+3
-19
lines changed

net/DevExtreme.AspNet.Data.Tests.NH/RemoteGroupingStress.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public DataItemMap() {
3030
//Map(i => i.DateO); //used by all fixtures, requires nh feature support (see skip)
3131
}
3232
}
33-
#pragma warning disable xUnit1004
33+
#pragma warning disable xUnit1004 // skip until external / dependency reason is resolved
3434
[Fact(Skip = "Skip until https://github.com/nhibernate/nhibernate-core/issues/2912 is implemented?")]
3535
#pragma warning restore xUnit1004
3636
public async Task Scenario() {

net/DevExtreme.AspNet.Data.Tests.Xpo/RemoteGroupingStress.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public DateOnly DateO {
5555
}
5656
//#endif
5757
}
58-
#pragma warning disable xUnit1004
58+
#pragma warning disable xUnit1004 // skip until external / dependency reason is resolved
5959
[Fact(Skip = "Skip until proper DevExpress.Xpo dll / nupkg with Date Time Only support?")]
6060
#pragma warning restore xUnit1004
6161
public async Task Scenario() {

net/DevExtreme.AspNet.Data.Tests/ResponseModelTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
namespace DevExtreme.AspNet.Data.Tests {
77

88
public class ResponseModelTests {
9-
#pragma warning disable xUnit1004
9+
#pragma warning disable xUnit1004 // skip until external / dependency reason is resolved
1010
[Fact(Skip = "Skip until consolidation or target bump to net7 and ShouldSerialize")]
1111
#pragma warning restore xUnit1004
1212
public void EmptyLoadResultSerialization() {

net/DevExtreme.AspNet.Data/Async/ReflectionAsyncAdapter.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,7 @@ static class EF6Methods {
6464
public static readonly MethodInfo CountAsyncMethod;
6565
public static readonly MethodInfo ToListAsyncMethod;
6666
static EF6Methods() {
67-
#pragma warning disable DX0004
6867
var extensionsType = Type.GetType("System.Data.Entity.QueryableExtensions, EntityFramework");
69-
#pragma warning restore DX0004
7068
CountAsyncMethod = FindCountAsyncMethod(extensionsType);
7169
ToListAsyncMethod = FindToListAsyncMethod(extensionsType);
7270
}
@@ -76,9 +74,7 @@ static class EFCoreMethods {
7674
public static readonly MethodInfo CountAsyncMethod;
7775
public static readonly MethodInfo ToListAsyncMethod;
7876
static EFCoreMethods() {
79-
#pragma warning disable DX0004
8077
var extensionsType = Type.GetType("Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions, Microsoft.EntityFrameworkCore");
81-
#pragma warning restore DX0004
8278
CountAsyncMethod = FindCountAsyncMethod(extensionsType);
8379
ToListAsyncMethod = FindToListAsyncMethod(extensionsType);
8480
}
@@ -88,9 +84,7 @@ static class NHMethods {
8884
public static readonly MethodInfo CountAsyncMethod;
8985
public static readonly MethodInfo ToListAsyncMethod;
9086
static NHMethods() {
91-
#pragma warning disable DX0004
9287
var extensionsType = Type.GetType("NHibernate.Linq.LinqExtensionMethods, NHibernate");
93-
#pragma warning restore DX0004
9488
CountAsyncMethod = FindCountAsyncMethod(extensionsType);
9589
ToListAsyncMethod = FindToListAsyncMethod(extensionsType);
9690
}
@@ -101,9 +95,7 @@ static class XpoMethods {
10195
public static readonly MethodInfo ToArrayAsyncMethod;
10296
static XpoMethods() {
10397
var asm = Array.Find(AppDomain.CurrentDomain.GetAssemblies(), a => a.FullName.StartsWith("DevExpress.Xpo.v"));
104-
#pragma warning disable DX0004
10598
var extensionsType = asm.GetType("DevExpress.Xpo.XPQueryExtensions");
106-
#pragma warning restore DX0004
10799
CountAsyncMethod = FindCountAsyncMethod(extensionsType);
108100
ToArrayAsyncMethod = FindToArrayAsyncMethod(extensionsType);
109101
}

net/DevExtreme.AspNet.Data/QueryProviderInfo.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,12 @@ public QueryProviderInfo(IQueryProvider provider) {
3838
switch(providerAssembly.GetName().Name) {
3939
case "LinqKit.Microsoft.EntityFrameworkCore":
4040
IsEFCore = true;
41-
#pragma warning disable DX0010
4241
providerAssembly = Assembly.Load("Microsoft.EntityFrameworkCore");
43-
#pragma warning restore DX0010
4442
break;
4543

4644
case "LinqKit.EntityFramework":
4745
IsEFClassic = true;
48-
#pragma warning disable DX0010
4946
providerAssembly = Assembly.Load("EntityFramework");
50-
#pragma warning restore DX0010
5147
break;
5248
}
5349
}

net/DevExtreme.AspNet.Data/Types/DynamicClassBridge.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,10 @@ static readonly MethodInfo
1616

1717
static DynamicClassBridge() {
1818
try {
19-
#pragma warning disable DX0010
2019
var assembly = Assembly.Load("System.Linq.Dynamic.Core");
21-
#pragma warning restore DX0010
22-
#pragma warning disable DX0004
2320
FACTORY_TYPE = assembly.GetType("System.Linq.Dynamic.Core.DynamicClassFactory");
2421
CLASS_TYPE = assembly.GetType("System.Linq.Dynamic.Core.DynamicClass");
2522
PROP_TYPE = assembly.GetType("System.Linq.Dynamic.Core.DynamicProperty");
26-
#pragma warning restore DX0004
2723
CREATE_TYPE_METHOD = FACTORY_TYPE.GetMethod("CreateType");
2824
INDEXER_METHOD = CLASS_TYPE.GetMethod("get_Item");
2925
} catch(FileNotFoundException x) {

0 commit comments

Comments
 (0)