refactor(Scheduler): address Copilot review comments for workspace PR

- m_work_space_indicator.ts: revert createIndicator to _createIndicator (used in subclass, cannot be private), remove stale comment
- m_timeline.ts: update calls to _createIndicator
- agenda.tests.js: update test name to match renamed method

Author: aleksei-semikozov

packages/devextreme/js/__internal/scheduler/workspaces/m_timeline.ts

@@ -462,13 +462,13 @@ class SchedulerTimeline extends SchedulerWorkSpace {
     const width = this.getIndicationWidth();
 
     if (this.option('groupOrientation') === 'vertical') {
-      $indicator = this.createIndicator($container);
+      $indicator = this._createIndicator($container);
       setHeight($indicator, getBoundingRect($container.get(0)).height);
       $indicator.css('left', rtlOffset ? rtlOffset - width : width);
     } else {
       for (let i = 0; i < groupCount; i++) {
         const offset = this.isGroupedByDate() ? i * this.getCellWidth() : this._getCellCount() * this.getCellWidth() * i;
-        $indicator = this.createIndicator($container);
+        $indicator = this._createIndicator($container);
         setHeight($indicator, getBoundingRect($container.get(0)).height);
 
         $indicator.css('left', rtlOffset ? rtlOffset - width - offset : width + offset);

packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_indicator.ts

@@ -64,7 +64,7 @@ class SchedulerWorkSpaceIndicator extends SchedulerWorkSpace {
     const groupedByDate = this.isGroupedByDate();
     const repeatCount = groupedByDate ? 1 : groupCount;
     for (let i = 0; i < repeatCount; i++) {
-      const $indicator = this.createIndicator($container);
+      const $indicator = this._createIndicator($container);
 
       setWidth(
         $indicator,
@@ -74,8 +74,7 @@ class SchedulerWorkSpaceIndicator extends SchedulerWorkSpace {
     }
   }
 
-  // Called from SchedulerTimeline._renderIndicator
-  createIndicator($container) {
+  _createIndicator($container) {
     const $indicator = $('<div>').addClass(SCHEDULER_DATE_TIME_INDICATOR_CLASS);
     $container.append($indicator);
 

packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/agenda.tests.js

@@ -61,7 +61,7 @@ module('Agenda', {}, () => {
         assert.deepEqual(firstViewDate, new Date(2016, 1, 17, 2), 'The first view date is OK');
     });
 
-    test('_removeEmptyRows method', async function(assert) {
+    test('removeEmptyRows method', async function(assert) {
         const rows = [[0, 0, 0, 0, 0], [0, 0, 0, 0, 1], [0, 0, 0, 0, 0], [1, 1, 1, 0, 1]];
 
         const instance = createInstance();