fix: copilot review

Author: web-flow

packages/devextreme/js/__internal/scheduler/m_scheduler.ts

@@ -540,7 +540,6 @@ class Scheduler extends SchedulerOptionsBaseWidget {
         this.updateOption('workSpace', name, value);
         this.repaint();
         break;
-      // @ts-expect-error
       case 'skippedDays':
         break;
       case 'indicatorTime':

packages/devextreme/js/__internal/scheduler/utils/options/types.ts

@@ -30,6 +30,7 @@ export interface SchedulerInternalOptions {
   disabledExpr: string;
   visibleExpr: string;
   allowMultipleCellSelection: boolean;
+  skippedDays?: number[];
 }
 
 export interface SchedulerOptionsRule {

packages/devextreme/js/__internal/scheduler/workspaces/m_agenda.ts

@@ -24,7 +24,7 @@ import { VIEWS } from '../utils/options/constants_view';
 import { reduceResourcesTree } from '../utils/resource_manager/agenda_group_utils';
 import type { GroupNode } from '../utils/resource_manager/types';
 import type { ListEntity } from '../view_model/types';
-import WorkSpace, { type WorkspaceDateTableScrollableConfig, type WorkspaceOptionChangedOptions, type WorkspaceOptionsInternal } from './m_work_space';
+import WorkSpace, { type WorkspaceOptionChangedOptions, type WorkspaceOptionsInternal } from './m_work_space';
 
 const { tableCreator } = tableCreatorModule;
 
@@ -394,11 +394,9 @@ class SchedulerAgenda extends WorkSpace {
 
   protected renderTableBody(
     options: AgendaRenderOptions,
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     delayCellTemplateRendering?: unknown,
   ): void {
-    if (delayCellTemplateRendering) {
-      noop();
-    }
     const cellTemplates: unknown[] = [];
     const cellTemplateOpt = options.cellTemplate as {
       render?: (templateOptions: unknown) => unknown;
@@ -448,7 +446,7 @@ class SchedulerAgenda extends WorkSpace {
     };
 
     for (i = 0; i < this.rows.length; i += 1) {
-      each(this.rows[i], fillTableBody.bind(this));
+      each(this.rows[i], fillTableBody);
       this.setLastRowClass();
     }
 
@@ -529,22 +527,12 @@ class SchedulerAgenda extends WorkSpace {
   updateScrollPosition(date: Date): void {
     const newDate = this.timeZoneCalculator.createDate(date, 'toGrid');
 
-    const bounds = this.getVisibleBounds();
-
-    if (this.needUpdateScrollPosition(newDate, bounds)) {
+    if (this.needUpdateScrollPosition(newDate)) {
       this.scrollTo(newDate);
     }
   }
 
-  needUpdateScrollPosition(
-    date: Date,
-    appointmentGroupValues?: unknown,
-    inAllDayRow?: boolean,
-  ): boolean {
-    if (appointmentGroupValues || inAllDayRow) {
-      noop();
-    }
-
+  override needUpdateScrollPosition(date: Date): boolean {
     const bounds = this.getVisibleBounds();
     const hours = date.getHours();
     const minutes = date.getMinutes();
@@ -558,7 +546,7 @@ class SchedulerAgenda extends WorkSpace {
       isUpdateNeeded = true;
     }
 
-    if (hours === bounds.bottom.hours && minutes > bounds.top.minutes) {
+    if (hours === bounds.bottom.hours && minutes > bounds.bottom.minutes) {
       isUpdateNeeded = true;
     }
 

packages/devextreme/js/__internal/scheduler/workspaces/m_timeline.ts

@@ -57,22 +57,18 @@ class SchedulerTimeline extends SchedulerWorkSpace {
 
   protected override getTotalRowCount(
     groupCount: number,
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     includeAllDayPanelRows?: unknown,
   ): number {
-    if (includeAllDayPanelRows !== undefined) {
-      noop();
-    }
-
     if (this.isHorizontalGroupedWorkSpace()) {
       return this.getRowCount();
     }
     const totalGroupCount = groupCount || 1;
     return this.getRowCount() * totalGroupCount;
   }
 
-  protected override getFormat(): string {
-    const format = getGlobalFormatByDataType('time');
-    return typeof format === 'string' ? format : 'shorttime';
+  protected override getFormat(): string | ((date: Date) => string) {
+    return getGlobalFormatByDataType('time') as string | ((date: Date) => string) || 'shorttime';
   }
 
   private getWorkSpaceHeight(): number {
@@ -413,9 +409,6 @@ class SchedulerTimeline extends SchedulerWorkSpace {
     $container: dxElementWrapper,
     groupCount: number,
   ): void {
-    if (height !== undefined) {
-      noop();
-    }
     // eslint-disable-next-line @typescript-eslint/init-declarations
     let $indicator: dxElementWrapper | undefined;
     const width = this.getIndicationWidth();

packages/devextreme/js/__internal/scheduler/workspaces/m_timeline_month.ts

@@ -39,7 +39,6 @@ class SchedulerTimelineMonth extends SchedulerTimeline {
     return true;
   }
 
-  // @ts-expect-error
   protected override getFormat(): (date: Date) => string {
     return formatWeekdayAndDay;
   }

packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts

@@ -10,6 +10,7 @@ import {
 import pointerEvents from '@js/common/core/events/pointer';
 import { addNamespace, isMouseEvent } from '@js/common/core/events/utils/index';
 import domAdapter from '@js/core/dom_adapter';
+import type { OptionChangedEventInfo } from '@js/core/dom_component';
 import { getPublicElement } from '@js/core/element';
 import type { dxElementWrapper } from '@js/core/renderer';
 import $ from '@js/core/renderer';
@@ -28,6 +29,7 @@ import {
 } from '@js/core/utils/size';
 import { isDefined } from '@js/core/utils/type';
 import { getWindow, hasWindow } from '@js/core/utils/window';
+import type { InitializedEventInfo } from '@js/events';
 import type { ScrollEvent } from '@js/ui/scroll_view';
 import errors from '@js/ui/widget/ui.errors';
 import Widget from '@js/ui/widget/ui.widget';
@@ -127,9 +129,9 @@ export interface WorkspaceDateTableScrollableConfig {
   bounceEnabled: boolean;
   updateManually: boolean;
   onScroll: (event: ScrollEvent) => void;
-  onInitialized: (args: { component: Scrollable }) => void;
-  onOptionChanged: (args: { fullName: string; value: unknown; component: Scrollable }) => void;
-  direction?: 'both';
+  onInitialized: (args: InitializedEventInfo<Scrollable>) => void;
+  onOptionChanged: (args: OptionChangedEventInfo<Scrollable>) => void;
+  direction?: 'horizontal' | 'vertical' | 'both';
   onEnd?: () => void;
 }
 
@@ -140,6 +142,7 @@ export interface WorkspaceHeaderScrollableConfig {
   useNative: false;
   updateManually: true;
   bounceEnabled: false;
+  scrollByContent?: boolean;
   onScroll: (event: ScrollEvent) => void;
 }
 
@@ -254,7 +257,7 @@ export type WorkspaceOptionChangedOptions = WorkspaceOptionsInternal & {
   scrolling?: unknown;
   schedulerHeight?: number;
   schedulerWidth?: number;
-  agendaDuration?: number | 'month';
+  agendaDuration?: number;
   rowHeight?: number;
   noDataText?: string;
   showCurrentTimeIndicator?: boolean;
@@ -736,14 +739,14 @@ class SchedulerWorkSpace extends Widget<WorkspaceOptionsInternal> {
       // To prevent scroll container focus in native mode we set tabindex -1 to container
       // In simulated mode focusable behavior prevented by useKeyboard: false private option
       onInitialized: ({ component }) => {
-        const useKeyboardDisabled = !(component.option('useKeyboard') as unknown as boolean);
-        const useNativeEnabled = component.option('useNative') as unknown as boolean;
+        const useKeyboardDisabled = (component?.option('useKeyboard') as unknown as boolean | undefined) === false;
+        const useNativeEnabled = (component?.option('useNative') as unknown as boolean | undefined) === true;
         if (useKeyboardDisabled && useNativeEnabled) {
-          $(component.container()).attr('tabindex', -1);
+          $(component?.container()).attr('tabindex', -1);
         }
       },
       onOptionChanged: ({ fullName, value, component }) => {
-        const useKeyboardDisabled = !(component.option('useKeyboard') as unknown as boolean);
+        const useKeyboardDisabled = (component.option('useKeyboard') as unknown as boolean | undefined) === false;
         if (useKeyboardDisabled && fullName === 'useNative' && value === true) {
           $(component.container()).attr('tabindex', -1);
         }
@@ -1320,7 +1323,7 @@ class SchedulerWorkSpace extends Widget<WorkspaceOptionsInternal> {
     });
   }
 
-  protected getFormat() { return abstract(); }
+  protected getFormat(): string | ((date: Date) => string) { return abstract(); }
 
   getWorkArea() {
     return this.$dateTableContainer;

packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_indicator.ts

@@ -76,15 +76,15 @@ class SchedulerWorkSpaceIndicator extends SchedulerWorkSpace {
   ): void {
     const groupedByDate = this.isGroupedByDate();
     const repeatCount = groupedByDate ? 1 : groupCount;
-    Array.from({ length: repeatCount }).forEach((_, i) => {
+    for (let i = 0; i < repeatCount; i += 1) {
       const $indicator = this.createIndicator($container);
 
       setWidth(
         $indicator,
         groupedByDate ? this.getCellWidth() * groupCount : this.getCellWidth(),
       );
       this.groupedStrategy.shiftIndicator($indicator, height, rtlOffset, i);
-    });
+    }
   }
 
   protected createIndicator($container: dxElementWrapper): dxElementWrapper {