Fix TypeError on accessing a component instance while unmounting (T1327953) (#33526)

Author: GoodDayForSurf

packages/devextreme-react/src/core/__tests__/props-updating.test.tsx

@@ -1042,6 +1042,38 @@ describe('cfg-component option control', () => {
     expect((optionsManager as any).setValue).toHaveBeenCalledTimes(1);
   });
 
+  it('does not crash when option change handler unmounts component (T1327953)', () => {
+    const optionsManager = new OptionsManagerModule.OptionsManager();
+    const config = {
+      name: '',
+      predefinedOptions: {},
+      initialOptions: {},
+      options: {
+        value: 1,
+        onValueChange: () => {
+          optionsManager.dispose();
+        },
+      },
+      templates: [],
+      configs: {},
+      configCollections: {},
+    };
+
+    optionsManager.setInstance({
+      skipOptionsRollBack: false,
+      option: jest.fn(),
+      resetOption: jest.fn(),
+      on: jest.fn(),
+      off: jest.fn(),
+      beginUpdate: jest.fn(),
+      endUpdate: jest.fn(),
+    }, config, ['value'], []);
+
+    expect(() => {
+      optionsManager.onOptionChanged({ name: 'value', value: 2, fullName: 'value' });
+    }).not.toThrow();
+  });
+
   it('apply cfg-component option change if value really change', () => {
     const TestContainer = (props: any) => {
       const { value } = props;

packages/devextreme-react/src/core/options-manager.ts

@@ -160,7 +160,7 @@ class OptionsManager {
         && e.value instanceof Object
         && shallowEquals(value as Record<string, unknown>, e.value as Record<string, unknown>);
 
-      if (valuesAreEqual || valuesAreEqualObjects || this.instance.skipOptionsRollBack) {
+      if (valuesAreEqual || valuesAreEqualObjects || this.instance?.skipOptionsRollBack) {
         return;
       }