Skip to content

Commit 5980046

Browse files
committed
Refactor Chrome headless shell setup to use pnpm for Puppeteer command execution
1 parent d7aa0a8 commit 5980046

2 files changed

Lines changed: 2 additions & 9 deletions

File tree

.github/actions/run-qunit-tests/action.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,6 @@ runs:
4242
echo "MATRIX_ENVS_NAME_SAFE=$MATRIX_ENVS_NAME_SAFE"
4343
echo "MATRIX_ENVS_NAME_SAFE=$MATRIX_ENVS_NAME_SAFE" >> $GITHUB_ENV
4444
45-
# - name: Update apt
46-
# run: |
47-
# sudo apt-get update
48-
49-
# - name: Setup utils
50-
# run: |
51-
# sudo apt-get install -y dbus-x11 httping x11vnc xvfb
52-
5345
- name: Setup Chrome
5446
if: ${{ inputs.browser == 'chrome' }}
5547
uses: ./.github/actions/setup-chrome-headless-shell

.github/actions/setup-chrome-headless-shell/action.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ runs:
1919
run: |
2020
if [ -n "$CHROME_VERSION" ]; then
2121
echo "version to install: $CHROME_VERSION"
22-
CHROME_BIN=`npx @puppeteer/browsers install chrome-headless-shell@$CHROME_VERSION | awk '{print $2}'`
22+
PUPPETEER_CMD="browsers install chrome-headless-shell@$CHROME_VERSION"
23+
CHROME_BIN=`pnpm --filter devextreme-angular exec puppeteer $PUPPETEER_CMD | awk '{print $2}'`
2324
chmod +x $CHROME_BIN
2425
echo "chrome-headless-shell installed in: $CHROME_BIN"
2526
$CHROME_BIN --version

0 commit comments

Comments
 (0)