Skip to content

Commit 7b9b886

Browse files
Playwright - dynamic padding for all viewports, use clientWidth for page screenshots
1 parent f7e0739 commit 7b9b886

3 files changed

Lines changed: 3 additions & 8 deletions

File tree

.github/workflows/playwright_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ jobs:
132132

133133
- name: Install Playwright browsers
134134
working-directory: ./e2e/testcafe-devextreme
135-
run: npx playwright install chrome
135+
run: npx playwright install chromium
136136

137137
- name: Run Playwright tests
138138
working-directory: ./e2e/testcafe-devextreme

e2e/testcafe-devextreme/playwright-helpers/themeUtils.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ async function takePageScreenshot(
4141
screenshotOptions?: { maxDiffPixelRatio?: number },
4242
): Promise<void> {
4343
const viewport = page.viewportSize() ?? { width: 1200, height: 800 };
44-
const htmlOffsetWidth = await page.evaluate(() => document.documentElement.offsetWidth);
45-
const width = Math.min(htmlOffsetWidth, viewport.width);
44+
const contentWidth = await page.evaluate(() => document.documentElement.clientWidth);
45+
const width = Math.min(contentWidth, viewport.width);
4646
const clip = { x: 0, y: 0, width, height: viewport.height };
4747
await expect(page).toHaveScreenshot([name], { maxDiffPixelRatio: 0.20, clip, ...screenshotOptions });
4848
}
@@ -68,9 +68,6 @@ async function takeElementScreenshot(
6868
}
6969

7070
async function simulateTestCafeScrollbar(page: Page): Promise<boolean> {
71-
const viewport = page.viewportSize();
72-
if (viewport && viewport.width !== 1200) return false;
73-
7471
return page.evaluate(() => {
7572
if (document.documentElement.style.paddingRight) return false;
7673

e2e/testcafe-devextreme/playwright.config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,12 @@ export default defineConfig({
123123
name: 'chromium',
124124
use: {
125125
browserName: 'chromium',
126-
...(process.env.CI ? { channel: 'chrome' } : {}),
127126
},
128127
},
129128
{
130129
name: 'chromium-1185',
131130
use: {
132131
browserName: 'chromium',
133-
...(process.env.CI ? { channel: 'chrome' } : {}),
134132
viewport: { width: 1185, height: 800 },
135133
},
136134
},

0 commit comments

Comments
 (0)