Skip to content

Commit 849adef

Browse files
authored
Stabilize Accessibility and Filtering tests (#33142)
1 parent a02d81f commit 849adef

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

e2e/testcafe-devextreme/tests/dataGrid/common/accessibility/bugs.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ fixture.disablePageReloads`Accessibility bugs`
88

99
test('T1187314 - DataGrid displays an incorrect row count in "aria-label" if there is no data after filtering', async (t) => {
1010
const dataGrid = new DataGrid('#container');
11+
await t.expect(dataGrid.isReady()).ok();
1112

1213
await dataGrid.apiFilter(['id', '=', '1']);
1314
await t
@@ -25,6 +26,7 @@ test('T1187314 - DataGrid displays an incorrect row count in "aria-label" if the
2526

2627
test('DataGrid - The \'aria-label\' attribute value is "Show filter options for column \'undefined\' for the header filter icon in grouped fields (T1205784)', async (t) => {
2728
const dataGrid = new DataGrid('#container');
29+
await t.expect(dataGrid.isReady()).ok();
2830

2931
await t
3032
.expect(dataGrid.getGroupPanel().getHeader(0).getFilterButton().getAttribute('aria-label'))
@@ -54,7 +56,7 @@ test('DataGrid - NVDA reads column information twice (T1286287)', async (t) => {
5456
const dataGrid = new DataGrid('#container');
5557
const dataCell = dataGrid.getDataCell(1, 1).element;
5658

57-
await dataGrid.isReady();
59+
await t.expect(dataGrid.isReady()).ok();
5860
await t
5961
.expect(dataCell.hasAttribute('aria-describedby'))
6062
.notOk();

e2e/testcafe-devextreme/tests/dataGrid/common/filtering/functional.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ const GRID_CONTAINER = '#container';
1111
test('Don\'t calculate additional filter when filtering column list is empty', async (t) => {
1212
// arrange
1313
const dataGrid = new DataGrid(GRID_CONTAINER);
14+
await t.expect(dataGrid.isReady()).ok();
1415
const consoleMessages = await t.getBrowserConsoleMessages();
1516

1617
// act

e2e/testcafe-devextreme/tests/dataGrid/common/filtering/visual.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ test('Data should be filtered if True is selected via the filter method when cas
1313
// arrange
1414
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
1515
const dataGrid = new DataGrid(GRID_CONTAINER);
16+
await t.expect(dataGrid.isReady()).ok();
1617

1718
// act
1819
await dataGrid.apiFilter(['text', '=', 'true']);

0 commit comments

Comments
 (0)