Skip to content

Commit 882162a

Browse files
author
marker dao ®
committed
revert(knockout)
1 parent c91c061 commit 882162a

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

packages/devextreme/js/__internal/ui/popover/m_popover.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,7 @@ class Popover<
229229
}
230230

231231
_detachEvent(target: PopoverTarget, name: string, event?: unknown) {
232+
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
232233
let eventName: string = event || this._getEventName(`${name}Event`);
233234

234235
if (!eventName) {
@@ -385,6 +386,7 @@ class Popover<
385386
const isHorizontal = this._isHorizontalSide() && isFlippedByHorizontal;
386387
const isInside = this._isPopoverInside();
387388

389+
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
388390
const condition = isVertical || isHorizontal || isInside;
389391
const positionSide = this._positionController._positionSide;
390392

packages/devextreme/js/__internal/ui/text_box/m_text_editor.base.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -678,8 +678,8 @@ class TextEditorBase<
678678
}
679679

680680
const $input = this._input();
681-
682-
const { placeholder } = this.option();
681+
// There should be no destructuring, because of knockout limitations
682+
const placeholder = this.option('placeholder');
683683

684684
const placeholderAttributes = {
685685
id: placeholder ? `dx-${new Guid()}` : undefined,

0 commit comments

Comments
 (0)