fix(nx-infra-plugin): apply license headers AFTER compress beautify to preserve banner indentation

Author: chaosmirage

packages/devextreme/project.json

@@ -745,12 +745,7 @@
       "options": {
         "files": [
           { "from": "./js/aspnet.js", "to": "./artifacts/js/dx.aspnet.mvc.js" }
-        ],
-        "applyLicenseHeaders": {
-          "targetSubdir": "./artifacts/js",
-          "separator": "",
-          "includePatterns": ["dx.aspnet.mvc.js"]
-        }
+        ]
       },
       "inputs": ["{projectRoot}/js/aspnet.js"],
       "outputs": ["{projectRoot}/artifacts/js/dx.aspnet.mvc.js"]
@@ -759,7 +754,12 @@
       "executor": "devextreme-nx-infra-plugin:compress",
       "options": {
         "files": ["./artifacts/js/dx.aspnet.mvc.js"],
-        "mode": { "name": "beautify" }
+        "mode": { "name": "beautify" },
+        "applyLicenseHeaders": {
+          "targetSubdir": "./artifacts/js",
+          "separator": "",
+          "includePatterns": ["dx.aspnet.mvc.js"]
+        }
       },
       "configurations": {
         "normalize": {

packages/nx-infra-plugin/src/executors/add-license-headers/schema.ts

@@ -11,3 +11,17 @@ export interface AddLicenseHeadersExecutorSchema {
   commentType?: '!' | '*';
   mode?: 'eula' | 'mit';
 }
+
+export interface ApplyLicenseHeadersOption {
+  licenseTemplateFile?: string;
+  mode?: 'eula' | 'mit';
+  eulaUrl?: string;
+  version?: string;
+  commentType?: '!' | '*';
+  separator?: string;
+  prependAfterLicense?: string;
+  filenameMode?: 'relative' | 'basename';
+  includePatterns?: readonly string[];
+  excludePatterns?: readonly string[];
+  targetSubdir?: string;
+}

packages/nx-infra-plugin/src/executors/compress/compress.impl.ts

@@ -6,12 +6,18 @@ import { createExecutor } from '../../utils/create-executor';
 import { expandEntries } from '../../utils/glob-discovery';
 import {
   ensureTrailingNewline,
+  loadProjectPackageJson,
   normalizeEol,
   readFileText,
   writeFileText,
 } from '../../utils/file-operations';
 import { CompressExecutorSchema, CompressMode, CompressModeName } from './schema';
-import { DEFAULT_EULA_URL } from '../add-license-headers/defaults';
+import { applyLicenseHeadersToDirectory } from '../add-license-headers/add-license-headers.impl';
+import { DEFAULT_EULA_URL, resolveLicenseTemplate } from '../add-license-headers/defaults';
+import type { ApplyLicenseHeadersOption } from '../add-license-headers/schema';
+
+const ERROR_APPLY_LICENSE_HEADERS_TARGET_SUBDIR_REQUIRED =
+  'Compress: applyLicenseHeaders.targetSubdir is required to specify the directory to apply headers to';
 
 const STRIP_DEBUG_REGEX = /\/{2,}\s{0,}#DEBUG[\s\S]*?\/{2,}\s{0,}#ENDDEBUG/g;
 
@@ -132,11 +138,41 @@ async function compressFile(filePath: string, mode: CompressMode): Promise<void>
   await writeFileText(filePath, await runStrategy(raw, resolved));
 }
 
+async function applyLicenseHeadersIfRequested(
+  applyLicenseHeaders: ApplyLicenseHeadersOption | undefined,
+  projectRoot: string,
+): Promise<void> {
+  if (!applyLicenseHeaders) {
+    return;
+  }
+  if (!applyLicenseHeaders.targetSubdir) {
+    throw new Error(ERROR_APPLY_LICENSE_HEADERS_TARGET_SUBDIR_REQUIRED);
+  }
+  const pkg = await loadProjectPackageJson(projectRoot);
+  const templatePath = resolveLicenseTemplate(projectRoot, applyLicenseHeaders);
+  const targetDir = path.join(projectRoot, applyLicenseHeaders.targetSubdir);
+  await applyLicenseHeadersToDirectory({
+    targetDir,
+    pkg,
+    templatePath,
+    eulaUrl: applyLicenseHeaders.eulaUrl ?? DEFAULT_EULA_URL,
+    mode: applyLicenseHeaders.mode,
+    version: applyLicenseHeaders.version,
+    commentType: applyLicenseHeaders.commentType,
+    separator: applyLicenseHeaders.separator,
+    prependAfterLicense: applyLicenseHeaders.prependAfterLicense,
+    filenameMode: applyLicenseHeaders.filenameMode,
+    includePatterns: applyLicenseHeaders.includePatterns,
+    excludePatterns: applyLicenseHeaders.excludePatterns,
+  });
+}
+
 interface ResolvedCompress {
   projectRoot: string;
   files: string[];
   mode: CompressMode;
   modeName: string;
+  applyLicenseHeaders?: ApplyLicenseHeadersOption;
 }
 
 export default createExecutor<CompressExecutorSchema, ResolvedCompress>({
@@ -151,12 +187,14 @@ export default createExecutor<CompressExecutorSchema, ResolvedCompress>({
       files: expanded,
       mode: options.mode,
       modeName: typeof options.mode === 'string' ? options.mode : options.mode.name,
+      applyLicenseHeaders: options.applyLicenseHeaders,
     };
   },
-  run: async ({ projectRoot, files, mode, modeName }) => {
+  run: async ({ projectRoot, files, mode, modeName, applyLicenseHeaders }) => {
     for (const filePath of files) {
       await compressFile(filePath, mode);
       logger.verbose(`Compressed ${path.relative(projectRoot, filePath)} (${modeName})`);
     }
+    await applyLicenseHeadersIfRequested(applyLicenseHeaders, projectRoot);
   },
 });

packages/nx-infra-plugin/src/executors/compress/schema.json

@@ -41,6 +41,24 @@
       "type": "array",
       "items": { "type": "string" },
       "description": "Glob patterns for files to exclude from compression (relative to project root)"
+    },
+    "applyLicenseHeaders": {
+      "type": "object",
+      "description": "When provided, applies DevExtreme license headers after compression. The targetSubdir field is required and resolves relative to the project root.",
+      "properties": {
+        "licenseTemplateFile": { "type": "string" },
+        "mode": { "type": "string", "enum": ["eula", "mit"] },
+        "eulaUrl": { "type": "string" },
+        "version": { "type": "string" },
+        "commentType": { "type": "string", "enum": ["!", "*"] },
+        "separator": { "type": "string" },
+        "prependAfterLicense": { "type": "string" },
+        "filenameMode": { "type": "string", "enum": ["relative", "basename"] },
+        "includePatterns": { "type": "array", "items": { "type": "string" } },
+        "excludePatterns": { "type": "array", "items": { "type": "string" } },
+        "targetSubdir": { "type": "string" }
+      },
+      "required": ["targetSubdir"]
     }
   },
   "required": ["files", "mode"]

packages/nx-infra-plugin/src/executors/compress/schema.ts

@@ -1,3 +1,5 @@
+import type { ApplyLicenseHeadersOption } from '../add-license-headers/schema';
+
 export type CompressModeName = 'minify' | 'beautify' | 'strip-debug' | 'normalize';
 
 export type CompressMode =
@@ -16,4 +18,5 @@ export interface CompressExecutorSchema {
   files: string[];
   mode: CompressMode;
   exclude?: string[];
+  applyLicenseHeaders?: ApplyLicenseHeadersOption;
 }

packages/nx-infra-plugin/src/executors/copy-files/schema.ts

@@ -1,16 +1,6 @@
-export interface ApplyLicenseHeadersOption {
-  licenseTemplateFile?: string;
-  mode?: 'eula' | 'mit';
-  eulaUrl?: string;
-  version?: string;
-  commentType?: '!' | '*';
-  separator?: string;
-  prependAfterLicense?: string;
-  filenameMode?: 'relative' | 'basename';
-  includePatterns?: readonly string[];
-  excludePatterns?: readonly string[];
-  targetSubdir?: string;
-}
+import type { ApplyLicenseHeadersOption } from '../add-license-headers/schema';
+
+export type { ApplyLicenseHeadersOption };
 
 export interface CopyFilesExecutorSchema {
   files: Array<{