Scheduler - Fix TS strict build errors in form refactor

Author: aleksei-semikozov

packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts

@@ -38,6 +38,8 @@ import { customizeFormItems } from './m_customize_form_items';
 import { RecurrenceForm } from './m_recurrence_form';
 import { createFormIconTemplate, getStartDateCommonConfig, RecurrenceRule } from './utils';
 
+type SchedulerEditingObject = Exclude<NonNullable<SchedulerProperties['editing']>, boolean>;
+
 export interface AppointmentFormConfig {
   dataAccessors: AppointmentDataAccessor;
   editing: SchedulerProperties['editing'];
@@ -232,12 +234,17 @@ export class AppointmentForm {
     this.createForm(customizedItems);
   }
 
-  private getEditingForm(): NonNullable<NonNullable<SchedulerProperties['editing']>['form']> | undefined {
+  private getEditingForm(): SchedulerEditingObject['form'] {
+    const editing = this.getEditingObject();
+    return editing?.form;
+  }
+
+  private getEditingObject(): SchedulerEditingObject | undefined {
     const { editing } = this.config;
     if (isBoolean(editing) || !editing) {
       return undefined;
     }
-    return editing.form ?? undefined;
+    return editing;
   }
 
   private getIconsShowMode(): AppointmentFormIconsShowMode {
@@ -512,8 +519,7 @@ export class AppointmentForm {
     timeItemOptions?: SimpleItem,
     timezoneItemOptions?: SimpleItem,
   ): GroupItem {
-    const { editing } = this.config;
-    const allowTimeZoneEditing = !isBoolean(editing) ? editing?.allowTimeZoneEditing : undefined;
+    const allowTimeZoneEditing = this.getEditingObject()?.allowTimeZoneEditing;
     const { startDateExpr, endDateExpr } = this.config.dataAccessors.expr;
     const isStartDateEditor = dateExpr === startDateExpr;
 
@@ -869,8 +875,7 @@ export class AppointmentForm {
 
   showMainGroup(): void {
     const currentHeight = this.dxPopup.option('height') as string | number | undefined;
-    const { editing } = this.config;
-    const configuredHeight = (!isBoolean(editing) && editing?.popup?.height) || 'auto';
+    const configuredHeight = this.getEditingObject()?.popup?.height ?? 'auto';
 
     if (typeof currentHeight === 'number') {
       this.dxPopup.option('height', configuredHeight);

packages/devextreme/js/__internal/scheduler/appointment_popup/utils.ts

@@ -13,7 +13,7 @@ import type { Rule } from '../recurrence/types';
 
 export const createFormIconTemplate = (iconName: string): () => dxElementWrapper => (): dxElementWrapper => getImageContainer(iconName) ?? $('<div>').addClass('dx-scheduler-form-icon-sized-gap');
 
-export const getStartDateCommonConfig = (firstDayOfWeek: string): SimpleItem => ({
+export const getStartDateCommonConfig = (firstDayOfWeek: number): SimpleItem => ({
   colSpan: 1,
   itemType: 'simple',
   editorType: 'dxDateBox',

packages/devextreme/js/__internal/scheduler/m_scheduler.ts

@@ -1139,8 +1139,8 @@ class Scheduler extends SchedulerOptionsBaseWidget {
       dataAccessors: this._dataAccessors,
       editing: this.editing,
       resourceManager: this.resourceManager,
-      firstDayOfWeek: this.option('firstDayOfWeek'),
-      startDayHour: this.option('startDayHour'),
+      firstDayOfWeek: this.option('firstDayOfWeek') ?? 0,
+      startDayHour: this.option('startDayHour') ?? 0,
       // @ts-expect-error
       createComponent: (element, component, options) => this._createComponent(element, component, options),
       getCalculatedEndDate: (startDateWithStartHour) => this._workSpace.calculateEndDate(startDateWithStartHour),