Skip to content

Commit d447cb0

Browse files
authored
Fix unstable tests (#33319)
1 parent 252ae6c commit d447cb0

File tree

3 files changed

+94
-0
lines changed

3 files changed

+94
-0
lines changed

e2e/testcafe-devextreme/tests/dataGrid/common/exportButton.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ test('allowExportSelectedData: false, menu: false', async (t) => {
1111
const dataGrid = new DataGrid('#container');
1212
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
1313

14+
await t.expect(dataGrid.isReady()).ok();
15+
1416
await testScreenshot(t, takeScreenshot, 'grid-export-one-button.png', { element: dataGrid.getHeaderPanel().element });
1517
await t
1618
.expect(compareResults.isValid())
@@ -26,6 +28,8 @@ test('allowExportSelectedData: false, menu: false, PDF', async (t) => {
2628
const dataGrid = new DataGrid('#container');
2729
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
2830

31+
await t.expect(dataGrid.isReady()).ok();
32+
2933
await testScreenshot(t, takeScreenshot, 'grid-export-one-button-pdf.png', { element: dataGrid.getHeaderPanel().element });
3034
await t
3135
.expect(compareResults.isValid())
@@ -43,6 +47,8 @@ test('allowExportSelectedData: true, menu: false', async (t) => {
4347
const dataGrid = new DataGrid('#container');
4448
const headerPanel = dataGrid.getHeaderPanel();
4549

50+
await t.expect(dataGrid.isReady()).ok();
51+
4652
await t.click(headerPanel.getExportButton().element);
4753

4854
await testScreenshot(t, takeScreenshot, 'grid-export-dropdown-button.png', { element: dataGrid.element });
@@ -65,6 +71,8 @@ test('allowExportSelectedData: false, menu: true', async (t) => {
6571
const dataGrid = new DataGrid('#container');
6672
const headerPanel = dataGrid.getHeaderPanel();
6773

74+
await t.expect(dataGrid.isReady()).ok();
75+
6876
await t.click(headerPanel.getDropDownMenuButton());
6977

7078
await testScreenshot(t, takeScreenshot, 'grid-export-one-button-in-menu.png', { element: 'html' });
@@ -85,6 +93,8 @@ test('allowExportSelectedData: true, menu: true', async (t) => {
8593
const dataGrid = new DataGrid('#container');
8694
const headerPanel = dataGrid.getHeaderPanel();
8795

96+
await t.expect(dataGrid.isReady()).ok();
97+
8898
await t.click(headerPanel.getDropDownMenuButton());
8999

90100
await testScreenshot(t, takeScreenshot, 'grid-export-dropdown-button-in-menu.png', { element: 'html' });
@@ -105,6 +115,7 @@ test.meta({ browserSize: [800, 800] })('Export is disabled when no data columns
105115
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
106116

107117
const dataGrid = new DataGrid('#container');
118+
await t.expect(dataGrid.isReady()).ok();
108119

109120
await testScreenshot(t, takeScreenshot, 'disabled-export_when-no-columns-visible.png', { element: dataGrid.element });
110121
await t
@@ -131,6 +142,8 @@ test.meta({ browserSize: [800, 800] })('Export is disabled when no data columns
131142
const dataGrid = new DataGrid('#container');
132143
const headerPanel = dataGrid.getHeaderPanel();
133144

145+
await t.expect(dataGrid.isReady()).ok();
146+
134147
await t.click(headerPanel.getDropDownMenuButton());
135148

136149
await testScreenshot(t, takeScreenshot, 'disabled-export-in-menu_when-no-columns-visible.png', { element: 'html' });

e2e/testcafe-devextreme/tests/dataGrid/common/grouping/grouping.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ test('Grouping Panel label should not overflow in a narrow grid (T1103925)', asy
1515

1616
const dataGrid = new DataGrid('#container');
1717

18+
await t.expect(dataGrid.isReady()).ok();
19+
1820
await testScreenshot(t, takeScreenshot, 'groupingPanel.png', { element: dataGrid.getToolbar().element });
1921
await t
2022
.expect(compareResults.isValid())
@@ -46,6 +48,8 @@ test('Headers should be rendered correctly after changing the grouping.autoExpan
4648
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
4749
const dataGrid = new DataGrid('#container');
4850

51+
await t.expect(dataGrid.isReady()).ok();
52+
4953
await testScreenshot(t, takeScreenshot, 'T1155453-expanded-groups.png', { element: dataGrid.element });
5054

5155
// act
@@ -96,6 +100,8 @@ test('Headers should be rendered correctly after changing the grouping.autoExpan
96100
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
97101
const dataGrid = new DataGrid('#container');
98102

103+
await t.expect(dataGrid.isReady()).ok();
104+
99105
await testScreenshot(t, takeScreenshot, 'T1155453-expanded-groups-with-fixed-content.png', { element: dataGrid.element });
100106

101107
// act
@@ -149,6 +155,8 @@ test.meta({ browserSize: [800, 800] })('Empty header message should appear when
149155

150156
const dataGrid = new DataGrid('#container');
151157

158+
await t.expect(dataGrid.isReady()).ok();
159+
152160
await testScreenshot(t, takeScreenshot, 'empty-header-message-with-selection-enabled.png', { element: dataGrid.element });
153161

154162
// assert
@@ -186,6 +194,8 @@ test('Group panel message should be vertically aligned (T1186613)', async (t) =>
186194
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
187195
const dataGrid = new DataGrid('#container');
188196

197+
await t.expect(dataGrid.isReady()).ok();
198+
189199
await testScreenshot(t, takeScreenshot, 'group-panel-message-align.png', { element: dataGrid.getToolbar().element });
190200
await t
191201
.expect(compareResults.isValid())
@@ -228,6 +238,8 @@ test('The collapse icon should update if repaintChangesOnly option is enabled (T
228238
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
229239
const dataGrid = new DataGrid('#container');
230240

241+
await t.expect(dataGrid.isReady()).ok();
242+
231243
await t.click(dataGrid.getPager().getNavPage('2').element);
232244

233245
await testScreenshot(t, takeScreenshot, 'continued_group-collapse_icon-T1201981.png', { element: dataGrid.element });
@@ -276,6 +288,8 @@ const customersT1232129 = [
276288
test('DataGrid loses grouping after the expandAll method if a grouped column has calculateDisplayValue (T1232129)', async (t) => {
277289
const dataGrid = new DataGrid('#container');
278290

291+
await t.expect(dataGrid.isReady()).ok();
292+
279293
await dataGrid.apiExpandAll();
280294
await t
281295
.expect(dataGrid.apiColumnOption('groupId', 'groupIndex'))
@@ -301,6 +315,8 @@ test('DataGrid loses grouping after the expandAll method if a grouped column has
301315
test('DataGrid should not lose grouping after the expandAll method if a grouped column has string calculateGroupValue (T1321187)', async (t) => {
302316
const dataGrid = new DataGrid('#container');
303317

318+
await t.expect(dataGrid.isReady()).ok();
319+
304320
await dataGrid.apiExpandAll();
305321

306322
await t
@@ -324,6 +340,8 @@ test('DataGrid should not change group column after the expandAll method, string
324340
const dataGrid = new DataGrid('#container');
325341
const firstGroupCellText = await dataGrid.getGroupRow(0).getCell(1).element.textContent;
326342

343+
await t.expect(dataGrid.isReady()).ok();
344+
327345
await dataGrid.apiExpandAll();
328346

329347
await t
@@ -353,6 +371,8 @@ test('DataGrid should not change group column after the expandAll method, string
353371
const dataGrid = new DataGrid('#container');
354372
const firstGroupCellText = await dataGrid.getGroupRow(0).getCell(1).element.textContent;
355373

374+
await t.expect(dataGrid.isReady()).ok();
375+
356376
await dataGrid.apiExpandAll();
357377

358378
await t

0 commit comments

Comments
 (0)