Scheduler — fix scrollTo method ignores single property alignInView (#32886)

Author: aleksei-semikozov

packages/devextreme/js/__internal/scheduler/__tests__/scheduler.test.ts

@@ -1,14 +1,47 @@
 import {
-  describe, expect, it, jest,
+  afterEach, beforeEach, describe, expect, it, jest,
 } from '@jest/globals';
 import { logger } from '@ts/core/utils/m_console';
 
 import { createScheduler } from './__mock__/create_scheduler';
 import { setupSchedulerTestEnvironment } from './__mock__/m_mock_scheduler';
 
-describe('Scheduler scrollTo deprecation', () => {
-  it('should log deprecation warning when using old scrollTo API', async () => {
+jest.mock('@ts/core/m_devices', () => {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  const originalModule: any = jest.requireActual('@ts/core/m_devices');
+  const real = jest.fn().mockReturnValue({
+    platform: 'mac',
+    mac: true,
+    deviceType: 'desktop',
+  });
+  const current = jest.fn().mockReturnValue({
+    platform: 'mac',
+    mac: true,
+    deviceType: 'desktop',
+  });
+
+  return {
+    __esModule: true,
+    default: {
+      ...originalModule.default,
+      isSimulator: originalModule.default.isSimulator,
+      real,
+      current,
+    },
+  };
+});
+
+describe('Scheduler scrollTo', () => {
+  beforeEach(() => {
     setupSchedulerTestEnvironment();
+    jest.spyOn(logger, 'warn').mockImplementation(() => {});
+  });
+
+  afterEach(() => {
+    document.body.innerHTML = '';
+  });
+
+  it('should log deprecation warning when using scrollTo API with deprecated signature', async () => {
     const loggerWarnSpy = jest.spyOn(logger, 'warn');
 
     const { scheduler } = await createScheduler({
@@ -25,9 +58,7 @@ describe('Scheduler scrollTo deprecation', () => {
     });
     loggerWarnSpy.mockReset();
 
-    const testDate = new Date(2025, 0, 16, 14, 0);
-
-    scheduler.scrollTo(testDate, undefined, false);
+    scheduler.scrollTo(new Date(2025, 0, 16, 14, 0), undefined, false);
 
     expect(loggerWarnSpy).toHaveBeenCalledTimes(1);
     expect(loggerWarnSpy).toHaveBeenCalledWith(
@@ -59,4 +90,27 @@ describe('Scheduler scrollTo deprecation', () => {
 
     expect(loggerWarnSpy).toHaveBeenCalledTimes(0);
   });
+
+  it('should pass different left offsets for "start" vs "center" alignInView', async () => {
+    const { container, scheduler } = await createScheduler({
+      dataSource: [],
+      views: ['timelineDay'],
+      currentView: 'timelineDay',
+      currentDate: new Date(2017, 4, 25),
+    });
+
+    const scrollableElement = container.querySelector('.dx-scheduler-date-table-scrollable') as HTMLElement;
+    const scrollableContainer = scrollableElement.querySelector('.dx-scrollable-container') as HTMLElement;
+
+    scheduler.scrollTo(new Date(2017, 4, 25, 22, 0), { alignInView: 'start' });
+    const startScrollLeft = scrollableContainer.scrollLeft;
+
+    scrollableContainer.scrollLeft = 0;
+
+    scheduler.scrollTo(new Date(2017, 4, 25, 22, 0), { alignInView: 'center' });
+    const centerScrollLeft = scrollableContainer.scrollLeft;
+
+    expect(startScrollLeft).toBeCloseTo(11000);
+    expect(centerScrollLeft).toBeCloseTo(11125);
+  });
 });

packages/devextreme/js/__internal/scheduler/m_scheduler.ts

@@ -2031,7 +2031,7 @@ class Scheduler extends SchedulerOptionsBaseWidget {
       align = groupValuesOrOptions.alignInView ?? 'center';
     } else {
       if (isDefined(groupValuesOrOptions) || isDefined(allDay)) {
-        errors.log('W0002', 'dxScheduler', 'scrollTo', '26.1', 'Use an object with "group", "allDay" and "alignInView" properties instead of separate parameters.');
+        errors.log('W0002', 'dxScheduler', 'scrollTo(date, group, allDay)', '26.1', 'Use scrollTo(date, { group, allDay, alignInView }) instead.');
       }
 
       groupValues = groupValuesOrOptions;
@@ -2043,7 +2043,7 @@ class Scheduler extends SchedulerOptionsBaseWidget {
 
   private _isScrollOptionsObject(options?: ScrollToGroupValuesOrOptions): options is ScrollToOptions {
     return Boolean(options) && typeof options === 'object'
-      && ('align' in options || 'allDay' in options || 'group' in options);
+      && ('alignInView' in options || 'allDay' in options || 'group' in options);
   }
 
   private isHorizontalVirtualScrolling() {