Skip to content

Commit ff20343

Browse files
Merge branch '26_1' into 26_1_dx_scss_nx_infra_p
2 parents abde169 + 23eab53 commit ff20343

15 files changed

Lines changed: 108 additions & 103 deletions

File tree

packages/devextreme-angular/src/ui/color-box/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,10 +295,10 @@ export class DxColorBoxComponent extends DxComponent implements OnDestroy, Contr
295295
296296
*/
297297
@Input()
298-
get fieldAddons(): FieldAddons {
298+
get fieldAddons(): FieldAddons | null {
299299
return this._getOption('fieldAddons');
300300
}
301-
set fieldAddons(value: FieldAddons) {
301+
set fieldAddons(value: FieldAddons | null) {
302302
this._setOption('fieldAddons', value);
303303
}
304304

@@ -918,7 +918,7 @@ export class DxColorBoxComponent extends DxComponent implements OnDestroy, Contr
918918
* This member supports the internal infrastructure and is not intended to be used directly from your code.
919919
920920
*/
921-
@Output() fieldAddonsChange: EventEmitter<FieldAddons>;
921+
@Output() fieldAddonsChange: EventEmitter<FieldAddons | null>;
922922

923923
/**
924924

packages/devextreme-angular/src/ui/drop-down-box/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,10 +304,10 @@ export class DxDropDownBoxComponent extends DxComponent implements OnDestroy, Co
304304
305305
*/
306306
@Input()
307-
get fieldAddons(): FieldAddons {
307+
get fieldAddons(): FieldAddons | null {
308308
return this._getOption('fieldAddons');
309309
}
310-
set fieldAddons(value: FieldAddons) {
310+
set fieldAddons(value: FieldAddons | null) {
311311
this._setOption('fieldAddons', value);
312312
}
313313

@@ -966,7 +966,7 @@ export class DxDropDownBoxComponent extends DxComponent implements OnDestroy, Co
966966
* This member supports the internal infrastructure and is not intended to be used directly from your code.
967967
968968
*/
969-
@Output() fieldAddonsChange: EventEmitter<FieldAddons>;
969+
@Output() fieldAddonsChange: EventEmitter<FieldAddons | null>;
970970

971971
/**
972972

packages/devextreme-angular/src/ui/select-box/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,10 +306,10 @@ export class DxSelectBoxComponent extends DxComponent implements OnDestroy, Cont
306306
307307
*/
308308
@Input()
309-
get fieldAddons(): FieldAddons {
309+
get fieldAddons(): FieldAddons | null {
310310
return this._getOption('fieldAddons');
311311
}
312-
set fieldAddons(value: FieldAddons) {
312+
set fieldAddons(value: FieldAddons | null) {
313313
this._setOption('fieldAddons', value);
314314
}
315315

@@ -1195,7 +1195,7 @@ export class DxSelectBoxComponent extends DxComponent implements OnDestroy, Cont
11951195
* This member supports the internal infrastructure and is not intended to be used directly from your code.
11961196
11971197
*/
1198-
@Output() fieldAddonsChange: EventEmitter<FieldAddons>;
1198+
@Output() fieldAddonsChange: EventEmitter<FieldAddons | null>;
11991199

12001200
/**
12011201

packages/devextreme-angular/src/ui/tag-box/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,10 +306,10 @@ export class DxTagBoxComponent extends DxComponent implements OnDestroy, Control
306306
307307
*/
308308
@Input()
309-
get fieldAddons(): FieldAddons {
309+
get fieldAddons(): FieldAddons | null {
310310
return this._getOption('fieldAddons');
311311
}
312-
set fieldAddons(value: FieldAddons) {
312+
set fieldAddons(value: FieldAddons | null) {
313313
this._setOption('fieldAddons', value);
314314
}
315315

@@ -1278,7 +1278,7 @@ export class DxTagBoxComponent extends DxComponent implements OnDestroy, Control
12781278
* This member supports the internal infrastructure and is not intended to be used directly from your code.
12791279
12801280
*/
1281-
@Output() fieldAddonsChange: EventEmitter<FieldAddons>;
1281+
@Output() fieldAddonsChange: EventEmitter<FieldAddons | null>;
12821282

12831283
/**
12841284

packages/devextreme-vue/src/color-box.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ const componentConfig = {
164164
dropDownOptions: Object as PropType<dxPopupOptions<any> | Record<string, any>>,
165165
editAlphaChannel: Boolean,
166166
elementAttr: Object as PropType<Record<string, any>>,
167-
fieldAddons: Object as PropType<FieldAddons | Record<string, any>>,
167+
fieldAddons: Object as PropType<FieldAddons | null | Record<string, any>>,
168168
fieldTemplate: {},
169169
focusStateEnabled: Boolean,
170170
height: [Number, String],

packages/devextreme-vue/src/drop-down-box.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ const componentConfig = {
173173
dropDownButtonTemplate: {},
174174
dropDownOptions: Object as PropType<dxPopupOptions<any> | Record<string, any>>,
175175
elementAttr: Object as PropType<Record<string, any>>,
176-
fieldAddons: Object as PropType<FieldAddons | Record<string, any>>,
176+
fieldAddons: Object as PropType<FieldAddons | null | Record<string, any>>,
177177
fieldTemplate: {},
178178
focusStateEnabled: Boolean,
179179
height: [Number, String],

packages/devextreme-vue/src/select-box.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ const componentConfig = {
200200
dropDownButtonTemplate: {},
201201
dropDownOptions: Object as PropType<dxPopupOptions<any> | Record<string, any>>,
202202
elementAttr: Object as PropType<Record<string, any>>,
203-
fieldAddons: Object as PropType<FieldAddons | Record<string, any>>,
203+
fieldAddons: Object as PropType<FieldAddons | null | Record<string, any>>,
204204
fieldTemplate: {},
205205
focusStateEnabled: Boolean,
206206
grouped: Boolean,

packages/devextreme-vue/src/tag-box.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ const componentConfig = {
207207
dropDownButtonTemplate: {},
208208
dropDownOptions: Object as PropType<dxPopupOptions<any> | Record<string, any>>,
209209
elementAttr: Object as PropType<Record<string, any>>,
210-
fieldAddons: Object as PropType<FieldAddons | Record<string, any>>,
210+
fieldAddons: Object as PropType<FieldAddons | null | Record<string, any>>,
211211
fieldTemplate: {},
212212
focusStateEnabled: Boolean,
213213
grouped: Boolean,

packages/devextreme/js/__internal/ui/drop_down_editor/m_drop_down_editor.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ class DropDownEditor<
224224
activeStateEnabled: true,
225225
dropDownButtonTemplate: 'dropDownButton',
226226
fieldTemplate: null,
227+
fieldAddons: null,
227228
openOnFieldClick: false,
228229
showDropDownButton: true,
229230
// eslint-disable-next-line no-void

packages/devextreme/js/__internal/ui/radio_group/m_radio_button.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import type { dxElementWrapper } from '@js/core/renderer';
88
import $ from '@js/core/renderer';
99
import type { DxEvent } from '@js/events';
1010
import type { OptionChanged } from '@ts/core/widget/types';
11-
import type { EditorProperties } from '@ts/ui/editor/editor';
11+
import type { EditorProperties, ValueChangedEvent } from '@ts/ui/editor/editor';
1212
import Editor from '@ts/ui/editor/editor';
1313

1414
const RADIO_BUTTON_CLASS = 'dx-radiobutton';
@@ -24,11 +24,10 @@ class RadioButton extends Editor {
2424

2525
_clickAction?: (event?: Record<string, unknown>) => void;
2626

27-
// eslint-disable-next-line @typescript-eslint/no-invalid-void-type
28-
_supportedKeys(): Record<string, (e: KeyboardEvent) => void | boolean> {
29-
const click = function (e) {
27+
_supportedKeys(): Record<string, (e: KeyboardEvent) => void> {
28+
const click = (e: KeyboardEvent): void => {
3029
e.preventDefault();
31-
this._clickAction({ event: e });
30+
this._clickAction?.({ event: e });
3231
};
3332
return {
3433
...super._supportedKeys(),
@@ -70,10 +69,12 @@ class RadioButton extends Editor {
7069
}
7170

7271
_initMarkup(): void {
72+
const { value } = this.option();
73+
7374
super._initMarkup();
7475

7576
this._renderIcon();
76-
this._renderCheckedState(this.option('value'));
77+
this._renderCheckedState(value);
7778
this._renderClick();
7879
this.setAria('role', 'radio');
7980
}
@@ -85,7 +86,7 @@ class RadioButton extends Editor {
8586
this.$element().append(this._$icon);
8687
}
8788

88-
_renderCheckedState(checked): void {
89+
_renderCheckedState(checked: boolean): void {
8990
this.$element()
9091
.toggleClass(RADIO_BUTTON_CHECKED_CLASS, checked)
9192
.find(`.${RADIO_BUTTON_ICON_CLASS}`)
@@ -94,10 +95,9 @@ class RadioButton extends Editor {
9495
}
9596

9697
_renderClick(): void {
97-
// @ts-expect-error ts-error
98-
const eventName = addNamespace(clickEventName, this.NAME);
98+
const eventName = addNamespace(clickEventName, this.NAME ?? '');
9999

100-
this._clickAction = this._createAction((args): void => {
100+
this._clickAction = this._createAction((args: { event: ValueChangedEvent }): void => {
101101
this._clickHandler(args.event);
102102
});
103103

@@ -107,7 +107,7 @@ class RadioButton extends Editor {
107107
});
108108
}
109109

110-
_clickHandler(e): void {
110+
_clickHandler(e: ValueChangedEvent): void {
111111
this._saveValueChangeEvent(e);
112112
this.option('value', true);
113113
this._saveValueChangeEvent(undefined);

0 commit comments

Comments
 (0)