DataGrid/TreeList: Implement AiPromptEditor#31289
Merged
Alyar666 merged 31 commits intoOct 17, 2025
Merged
Conversation
Alyar666
force-pushed
the
datagrid_ai_prompt_editor_25_2
branch
from
271da94 to
46b3872
Compare
added 21 commits
October 10, 2025 18:03
…Add the stop button
…in AiPromptEditor
…hading on/off switch. Enable closing a popup window when clicking outside of it.
…Height/height to textarea
Alyar666
force-pushed
the
datagrid_ai_prompt_editor_25_2
branch
from
46b3872 to
01ada70
Compare
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 14, 2025
Raushen
reviewed
Oct 16, 2025
| action?: AiPromptEditorAction, | ||
| action: AiPromptEditorAction, | ||
| ): void { | ||
| // eslint-disable-next-line default-case |
Contributor
There was a problem hiding this comment.
Minor: Usually by default we can throw new exception "Unknown command"
Raushen
reviewed
Oct 16, 2025
|
|
||
| public isApplyButtonVisible(): boolean { | ||
| const applyButton = this.getApplyButtonElement(); | ||
| public isApplyToolbarItemVisible(): boolean { |
Contributor
There was a problem hiding this comment.
Minor: I'd suggest to avoid this method too. There are two ways:
- Create Toolbar and ToolbarItem POM where create methods Toolbar.getItemByText and ToolbarItem.isVisible
- On the Button POM level create method areParentsVisible where it iterates all parents up to body and check its visibility by checking display: none. It seems it would be easier way.
Raushen
approved these changes
Oct 16, 2025
arman-boyakhchyan
approved these changes
Oct 17, 2025
EugeniyKiyashko
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.