Skip to content

Demos: fix eslint warnings #31329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pharret31 merged 3 commits into from
Oct 14, 2025
Merged

Demos: fix eslint warnings #31329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6de699
Fix stylelint issues
pharret31 Oct 14, 2025
33b622a
Fix ci
pharret31 Oct 14, 2025
da48f14
Fix ci
pharret31 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 7 additions & 41 deletions .github/workflows/demos_visual_tests_frameworks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,13 @@ jobs:

if [ -f "changed-files.json" ]; then
echo "Running lint-demos on changed files"
CHANGED_DEMOS=$(jq -r '.[].filename' changed-files.json | grep '^apps/demos/Demos/' | sed 's|^apps/demos/||' | tr '\n' ' ')
CHANGED_DEMOS=$(jq -r '.[].filename' changed-files.json \
| grep '^apps/demos/Demos/' \
| sed 's|^apps/demos/||' \
| while read f; do
[ -f "$f" ] && echo "$f"
done \
| tr '\n' ' ')
if [ ! -z "$CHANGED_DEMOS" ]; then
echo "Changed demo files: $CHANGED_DEMOS"
pnpx eslint $CHANGED_DEMOS
Expand All @@ -327,46 +333,6 @@ jobs:
pnpm run lint-demos
fi

- name: Run lint on changed demos
if: github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'force all tests')
working-directory: apps/demos
env:
DEBUG: 'eslint:cli-engine,stylelint:standalone'
run: |
pnpx nx lint-non-demos

if [ -f "changed-files.json" ]; then
echo "Running lint-demos on changed files"
CHANGED_DEMOS=$(jq -r '.[].filename' changed-files.json | grep '^apps/demos/Demos/' | sed 's|^apps/demos/||' | tr '\n' ' ')
if [ ! -z "$CHANGED_DEMOS" ]; then
echo "Changed demo files: $CHANGED_DEMOS"
pnpx eslint $CHANGED_DEMOS
else
echo "No demo files changed, skipping lint-demos"
fi
else
echo "changed-files.json not found"
pnpm run lint-demos
fi

- name: Run lint on changed demos
if: github.event_name != 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'force all tests')
working-directory: apps/demos
env:
DEBUG: 'eslint:cli-engine,stylelint:standalone'
run: |
pnpx nx lint-non-demos

if [ -f "changed-files.json" ]; then
echo "Running lint-demos on changed files"
CHANGED_DEMOS=$(jq -r '.[].filename' changed-files.json | grep '^apps/demos/Demos/' | sed 's|^apps/demos/||' | tr '\n' ' ')
if [ ! -z "$CHANGED_DEMOS" ]; then
echo "Changed demo files: $CHANGED_DEMOS"
pnpx eslint $CHANGED_DEMOS
else
echo "No demo files changed, skipping lint-demos"
fi

check_generated_demos:
name: ${{ matrix.name }}
runs-on: ubuntu-22.04
Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/AreaSparklines/Angular/app/app.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
::ng-deep .demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

::ng-deep .demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/AreaSparklines/React/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/AreaSparklines/ReactJs/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Charts/AreaSparklines/Vue/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const years = ['2010', '2011', '2012'];
.demo-table th {
font-weight: 400;
width: 200px;
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Charts/AreaSparklines/Vue/RowTemplate.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ withDefaults(defineProps<{
.rows-content td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/AreaSparklines/jQuery/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/BarSparklines/Angular/app/app.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
::ng-deep .demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

::ng-deep .demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/BarSparklines/React/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/BarSparklines/ReactJs/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/BarSparklines/Vue/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ function onValueChanged({ value }: DxSelectBoxTypes.ValueChangedEvent) {
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Charts/BarSparklines/Vue/RowTemplate.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const getValueField = (name) => name + props.year;
.rows-content td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/BarSparklines/jQuery/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Charts/PieAnnotations/Angular/app/app.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
::ng-deep .medal-tooltip .country-name {
font-size: 14px;
font-weight: 700;
margin: 5px 0 10px 0;
margin: 5px 0 10px;
}

::ng-deep .medal-tooltip .caption {
Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Charts/PieAnnotations/React/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
.medal-tooltip .country-name {
font-size: 14px;
font-weight: 700;
margin: 5px 0 10px 0;
margin: 5px 0 10px;
}

.medal-tooltip .caption {
Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Charts/PieAnnotations/ReactJs/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
.medal-tooltip .country-name {
font-size: 14px;
font-weight: 700;
margin: 5px 0 10px 0;
margin: 5px 0 10px;
}

.medal-tooltip .caption {
Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Charts/PieAnnotations/Vue/TooltipTemplate.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const data = ref(props.annotation.data);
.medal-tooltip .country-name {
font-size: 14px;
font-weight: 700;
margin: 5px 0 10px 0;
margin: 5px 0 10px;
}

.medal-tooltip .caption {
Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Charts/PieAnnotations/jQuery/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
.medal-tooltip .country-name {
font-size: 14px;
font-weight: 700;
margin: 5px 0 10px 0;
margin: 5px 0 10px;
}

.medal-tooltip .caption {
Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/SimpleBullets/Angular/app/app.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
::ng-deep .demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #e5e5e5;
}

::ng-deep .demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/SimpleBullets/React/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #e5e5e5;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/SimpleBullets/ReactJs/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #e5e5e5;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/SimpleBullets/Vue/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ const customizeTooltip = ({ value, target }) => ({
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #e5e5e5;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/SimpleBullets/jQuery/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #e5e5e5;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/SimpleSparklines/Angular/app/app.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
::ng-deep .demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

::ng-deep .demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/SimpleSparklines/React/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demos/Demos/Charts/SimpleSparklines/ReactJs/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
.demo-table td {
font-weight: 400;
width: 200px;
padding: 25px 10px 5px 10px;
padding: 25px 10px 5px;
border: 1px solid #c2c2c2;
}

.demo-table th {
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Charts/SimpleSparklines/Vue/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const years = ['2010', '2011', '2012'];
.demo-table th {
font-weight: 400;
width: 200px;
padding: 25px 15px 20px 15px;
padding: 25px 15px 20px;
border: 1px solid #c2c2c2;
}

Expand Down
Loading
Loading