e2e demos tests: switch on native automation by EugeniyKiyashko · Pull Request #31362 · DevExpress/DevExtreme

EugeniyKiyashko · 2025-10-15T20:43:51Z

No description provided.

Copilot

Pull Request Overview

This PR modifies TestCafe configuration for demo visual tests, removing the disableNativeAutomation flag and standardizing HTML meta tags across demo files.

Key Changes

Removes disableNativeAutomation: true from TestCafe runner configuration
Adds locale environment variables (LANG and LC_ALL) set to UTF-8
Adds --disable-dev-shm-usage Chrome flag to the browser configuration
Simplifies meta tags in HTML demo files by consolidating charset declarations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
apps/demos/utils/visual-tests/testcafe-runner.ts	Removes native automation disable flag, adds locale env vars, and adds Chrome flag for shared memory
apps/demos/Demos/Charts/ClientSideDataProcessing/jQuery/index.html	Consolidates meta tags: replaces separate IE compatibility and content-type tags with single charset meta tag
apps/demos/Demos/Charts/ClientSideDataProcessing/Angular/index.html	Consolidates meta tags: replaces separate IE compatibility and content-type tags with single charset meta tag
apps/demos/Demos/Charts/AxisCustomPosition/jQuery/index.html	Consolidates meta tags: replaces separate IE compatibility and content-type tags with single charset meta tag

Copilot

Pull Request Overview

Copilot reviewed 99 out of 222 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

apps/demos/testing/common.test.ts:1

The closing brace on line 200 creates an incorrect nesting structure. The console message assertions (lines 191-199) should execute regardless of the framework type, not only when comparisonResult is truthy. This appears to be a brace placement error that changes the intended control flow.

import { glob } from 'glob';

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…o/DevExtreme into 25_1_romans_issue

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull Request Overview

Copilot reviewed 104 out of 1587 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

apps/demos/Demos/Common/EditorAppearanceVariants/test-code.js:1

The test-code.js file is now empty. This will cause the test to have no setup logic, which may result in test failures or inability to capture proper screenshots. If this test is no longer needed, the file should be removed entirely rather than emptied.

Copilot · 2025-10-28T15:41:39Z

+            //  undefined,
+            //  comparisonOptions && {
+            //   ...comparisonOptions,
+            //   looksSameComparisonOptions: { antialiasingTolerance: 10 },
+            // });


Commented-out code should be removed rather than left in the codebase. If this code represents a temporary change that might need to be reverted, consider using feature flags or environment variables instead.

Suggested change

// undefined,

// comparisonOptions && {

// ...comparisonOptions,

// looksSameComparisonOptions: { antialiasingTolerance: 10 },

// });

Copilot · 2025-10-28T15:41:39Z

+            // });
          } else {
-            comparisonResult = await compareScreenshot(t, `${testName}${getThemePostfix(testTheme)}.png`, undefined, comparisonOptions);
+            comparisonResult = await compareScreenshot(t, `${testName}${getThemePostfix(testTheme)}.png`);


Both branches of the if-else statement now execute identical code. Consider removing the conditional and using a single call to compareScreenshot for both isGitHubDemos cases.

Copilot

Pull Request Overview

Copilot reviewed 104 out of 1593 changed files in this pull request and generated 2 comments.

Copilot

Pull Request Overview

Copilot reviewed 104 out of 1594 changed files in this pull request and generated 1 comment.

Copilot

Pull Request Overview

Copilot reviewed 104 out of 1594 changed files in this pull request and generated 3 comments.

Copilot

Pull Request Overview

Copilot reviewed 104 out of 1595 changed files in this pull request and generated 1 comment.

Copilot

Pull Request Overview

Copilot reviewed 104 out of 1597 changed files in this pull request and generated no new comments.

Copilot

Pull Request Overview

Copilot reviewed 104 out of 1594 changed files in this pull request and generated 1 comment.

Copilot

Pull Request Overview

Copilot reviewed 104 out of 1597 changed files in this pull request and generated no new comments.

Copilot

Pull Request Overview

Copilot reviewed 103 out of 1596 changed files in this pull request and generated 1 comment.

Copilot

Pull Request Overview

Copilot reviewed 103 out of 1596 changed files in this pull request and generated 1 comment.

Copilot

Pull Request Overview

Copilot reviewed 103 out of 1596 changed files in this pull request and generated no new comments.

Copilot

Pull Request Overview

Copilot reviewed 103 out of 1596 changed files in this pull request and generated no new comments.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 3ed53f0 to e515722 Compare October 15, 2025 22:02

Copilot AI review requested due to automatic review settings October 20, 2025 19:25

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from e515722 to 3bfba8a Compare October 20, 2025 19:25

EugeniyKiyashko requested a review from a team as a code owner October 20, 2025 19:25

Copilot AI reviewed Oct 20, 2025

View reviewed changes

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 3bfba8a to 960ab15 Compare October 20, 2025 20:02

EugeniyKiyashko requested a review from a team as a code owner October 20, 2025 20:02

Copilot AI review requested due to automatic review settings October 20, 2025 20:51

EugeniyKiyashko requested a review from a team as a code owner October 20, 2025 20:51

Copilot AI reviewed Oct 20, 2025

View reviewed changes

e2e demos tests: switch on disable native automation

428c50c

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 65bd7b1 to 4c42e0b Compare October 21, 2025 06:23

update etalons

3bdc5a4

Copilot AI review requested due to automatic review settings October 21, 2025 06:52

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 4c42e0b to 3bdc5a4 Compare October 21, 2025 06:52

EugeniyKiyashko requested a review from a team as a code owner October 21, 2025 06:52

Copilot AI reviewed Oct 21, 2025

View reviewed changes

replace etalons

5e70d3d

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 5e70d3d to 8770346 Compare October 22, 2025 08:34

Copilot AI review requested due to automatic review settings October 22, 2025 08:34

EugeniyKiyashko self-assigned this Oct 22, 2025

Copilot AI reviewed Oct 22, 2025

View reviewed changes

EugeniyKiyashko added 3 commits October 22, 2025 21:46

e2e demos tests: switch on disable native automation

8bee1c3

update etalons

bede550

replace etalons

229f2a1

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 8770346 to 229f2a1 Compare October 22, 2025 17:46

EugeniyKiyashko added 2 commits October 22, 2025 21:55

Merge branch '25_1_romans_issue' of https://github.com/EugeniyKiyashk…

cf654cc

…o/DevExtreme into 25_1_romans_issue

change chrome options

9600647

Copilot AI review requested due to automatic review settings October 22, 2025 17:57

Copilot AI reviewed Oct 22, 2025

View reviewed changes

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 30320b4 to 8594e6f Compare October 28, 2025 15:33

Copilot AI review requested due to automatic review settings October 28, 2025 15:39

Copilot AI reviewed Oct 28, 2025

View reviewed changes

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from b8cb9e2 to 988a7e9 Compare October 28, 2025 18:31

Copilot AI reviewed Oct 28, 2025

View reviewed changes

Comment thread apps/demos/Demos/Charts/ClientSideDataProcessing/Angular/index.html Outdated

Comment thread apps/demos/Demos/Charts/AxisCustomPosition/jQuery/index.html Outdated

Copilot AI reviewed Oct 28, 2025

View reviewed changes

Comment thread apps/demos/testing/common.test.ts Outdated

try use shr2 runners

0a94065

Copilot AI reviewed Oct 29, 2025

View reviewed changes

Comment thread apps/demos/testing/common.test.ts Outdated

Comment thread .github/workflows/demos_visual_tests_frameworks.yml Outdated

Comment thread .github/workflows/demos_visual_tests.yml Outdated

Copilot AI reviewed Oct 29, 2025

View reviewed changes

Comment thread apps/demos/testing/common.test.ts Outdated

stabilize

5b879f3

Copilot AI reviewed Oct 29, 2025

View reviewed changes

Comment thread .github/workflows/demos_visual_tests_frameworks.yml Outdated

Copilot AI reviewed Oct 29, 2025

View reviewed changes

Comment thread apps/demos/testing/common.test.ts

r-farkhutdinov previously approved these changes Oct 29, 2025

View reviewed changes

update

c39f449

Copilot AI reviewed Oct 29, 2025

View reviewed changes

Comment thread apps/demos/Demos/Gantt/Validation/test-code.js

alexslavr previously approved these changes Oct 29, 2025

View reviewed changes

Zedwag previously approved these changes Oct 29, 2025

View reviewed changes

Copilot AI reviewed Oct 29, 2025

View reviewed changes

r-farkhutdinov previously approved these changes Oct 29, 2025

View reviewed changes

Merge branch '25_2' into 25_1_romans_issue

592c794

alexslavr approved these changes Oct 29, 2025

View reviewed changes

r-farkhutdinov approved these changes Oct 29, 2025

View reviewed changes

pharret31 approved these changes Oct 29, 2025

View reviewed changes

Zedwag approved these changes Oct 29, 2025

View reviewed changes

Copilot AI reviewed Oct 29, 2025

View reviewed changes

Alyar666 approved these changes Oct 29, 2025

View reviewed changes

aleksei-semikozov approved these changes Oct 29, 2025

View reviewed changes

Conversation

EugeniyKiyashko commented Oct 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment