Skip to content

PivotGrid: Non-visible field headers are being exported into Excel #31533

Merged
AlisherAmonulloev merged 7 commits into
25_2from
25_2_attempt_to_fix_pg_export
Nov 10, 2025
Merged

PivotGrid: Non-visible field headers are being exported into Excel #31533
AlisherAmonulloev merged 7 commits into
25_2from
25_2_attempt_to_fix_pg_export

Conversation

@AlisherAmonulloev

@AlisherAmonulloev AlisherAmonulloev commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR fixed the issue described here: T1309823

@AlisherAmonulloev AlisherAmonulloev self-assigned this Oct 30, 2025
Copilot AI review requested due to automatic review settings October 30, 2025 12:05
Copilot AI reviewed Oct 30, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes an issue in the PivotGrid Excel export functionality where fields marked as visible: false were still being included in the exported field headers. The fix ensures that only visible fields are exported, consistent with the behavior verified by existing tests.

Copilot AI review requested due to automatic review settings November 2, 2025 14:07
Copilot AI reviewed Nov 2, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread packages/devextreme/testing/tests/DevExpress.exporter/exceljsParts/exceljs.pivotGrid.tests.js Outdated
Copilot AI review requested due to automatic review settings November 10, 2025 09:16
@AlisherAmonulloev AlisherAmonulloev changed the title Update export_pivot_grid.ts PivotGrid: Non-visible field headers are being exported into Excel Nov 10, 2025
Copilot AI reviewed Nov 10, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

aleksei-semikozov
aleksei-semikozov reviewed Nov 10, 2025
View reviewed changes
Comment thread packages/devextreme/testing/tests/DevExpress.exporter/exceljsParts/exceljs.pivotGrid.tests.js Outdated
Comment thread packages/devextreme/testing/tests/DevExpress.exporter/exceljsParts/exceljs.pivotGrid.tests.js Outdated
Copilot AI review requested due to automatic review settings November 10, 2025 11:58
Copilot AI reviewed Nov 10, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@AlisherAmonulloev AlisherAmonulloev merged commit cd767d5 into 25_2 Nov 10, 2025
120 of 127 checks passed
@AlisherAmonulloev AlisherAmonulloev deleted the 25_2_attempt_to_fix_pg_export branch November 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@aleksei-semikozov aleksei-semikozov aleksei-semikozov approved these changes

Assignees

@AlisherAmonulloev AlisherAmonulloev

Labels

25_2 type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlisherAmonulloev @aleksei-semikozov