Scheduler - Update Templates Demo for jQuery#31605
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the scheduler appointment popup functionality and updates a jQuery demo. The main changes include reordering method calls in the popup initialization, renaming editor name constants for consistency, and completely refactoring the demo's form customization with improved UI.
- Refactored appointment popup form initialization to improve timing and remove redundant toolbar updates
- Updated editor name constants to have an "Editor" suffix for better clarity and consistency
- Redesigned the jQuery Templates demo with a modernized form layout and visual styling
Reviewed Changes
Copilot reviewed 5 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| m_popup.ts | Removed premature updateToolbarForMainGroup() call and moved showMainGroup(false) to after form data is set |
| m_form.ts | Renamed editor name constants to include "Editor" suffix (e.g., startDate → startDateEditor) |
| jQuery/index.js | Complete refactor of form customization with custom template, improved event handling, and modern UI components |
| jQuery/styles.css | Updated styles for the modernized demo with new layout classes and visual improvements |
| jQuery/data.js | Changed movie color palette to softer pastel colors |
| if (canceled) { | ||
| e.cancel = true; | ||
| } else { | ||
| this.updateToolbarForMainGroup(); |
Contributor
There was a problem hiding this comment.
We are really should remove this line?
Contributor
Author
There was a problem hiding this comment.
Yep, that's a duplicate invocation of updateToolbarForMainGroup. Because already have this callstack:
_onShowing ->
_updateForm ->
showMainGroup ->
updateToolbarForMainGroup
Sorry for the unrelated change in the PR, but I have noticed it and was afraid that I would forgot about that.
aleksei-semikozov
previously approved these changes
Nov 13, 2025
aleksei-semikozov
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.