Scheduler — Replace underscore-prefixed: Workspace group (agenda, timeline, month, indicator)#32797
Merged
aleksei-semikozov merged 12 commits intoDevExpress:26_1from Mar 17, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors DevExtreme Scheduler internal workspace implementations to remove underscore-prefixed members (agenda/timeline/month/indicator) and updates Scheduler QUnit tests to use the new member names.
Changes:
- Renamed several underscore-prefixed methods/properties to non-underscore equivalents across agenda/timeline/month/indicator workspaces (with updated call sites/overrides).
- Updated Scheduler agenda unit/integration tests to stub/call the renamed workspace members.
- Tightened visibility for some refactored members (e.g.,
private) in internal workspace classes.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.agenda.tests.js | Updates integration tests to use getRowHeight and rows instead of underscore-prefixed members. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/agenda.tests.js | Updates unit tests to call recalculateAgenda / removeEmptyRows instead of underscore-prefixed methods. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_month.ts | Renames month workspace helpers and updates binding used during table rendering. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_indicator.ts | Renames indicator API (renderIndicator, createIndicator, etc.) and updates internal usage. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_timeline_work_week.ts | Renames and re-wires date-increment override to incrementDate. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_timeline_week.ts | Renames week header/date increment hooks to non-underscore methods. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_timeline_month.ts | Renames duration calculation hook to calculateDurationInCells. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_timeline_day.ts | Renames week header rendering hook to needRenderWeekHeader. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_timeline.ts | Updates timeline workspace to call renamed indicator/week-header/date-increment hooks and adjusts related helpers. |
| packages/devextreme/js/__internal/scheduler/workspaces/m_agenda.ts | Refactors agenda workspace internal state/methods away from underscore-prefixed names and updates internal calls. |
…eline, month, indicator)
- m_work_space_indicator.ts: revert createIndicator to _createIndicator (used in subclass, cannot be private), remove stale comment - m_timeline.ts: update calls to _createIndicator - agenda.tests.js: update test name to match renamed method
…h createIndicator method
aleksei-semikozov
force-pushed
the
3519-workspace-group-replace-underscore-partial
branch
from
087d578 to
59bcda1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
Tucchhaa
reviewed
Mar 13, 2026
Tucchhaa
reviewed
Mar 13, 2026
Tucchhaa
reviewed
Mar 13, 2026
Tucchhaa
reviewed
Mar 13, 2026
Tucchhaa
reviewed
Mar 13, 2026
| _getToday: any; | ||
| protected getToday?(): Date; | ||
|
|
||
| _$allDayPanel: any; |
Contributor
There was a problem hiding this comment.
why not put private and protected modifier to other props in this class?
Contributor
Author
There was a problem hiding this comment.
It's out of scope task, here I refactor agenda, timeline, month, indicator
Contributor
There was a problem hiding this comment.
As I see in the epic card, m_work_space.ts file is already marked as refactored. So why this prop still have an underscore? When we will remove them?
Tucchhaa
reviewed
Mar 13, 2026
Tucchhaa
reviewed
Mar 16, 2026
Tucchhaa
reviewed
Mar 16, 2026
Tucchhaa
reviewed
Mar 16, 2026
Tucchhaa
reviewed
Mar 16, 2026
Tucchhaa
reviewed
Mar 16, 2026
Tucchhaa
reviewed
Mar 16, 2026
Tucchhaa
reviewed
Mar 16, 2026
Tucchhaa
reviewed
Mar 16, 2026
Tucchhaa
reviewed
Mar 16, 2026
Tucchhaa
reviewed
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
aleksei-semikozov
force-pushed
the
3519-workspace-group-replace-underscore-partial
branch
from
33bbda9 to
0b5d447
Compare
aleksei-semikozov
force-pushed
the
3519-workspace-group-replace-underscore-partial
branch
from
0b5d447 to
03a9ffc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
…code, rename underscore-prefixed members
aleksei-semikozov
force-pushed
the
3519-workspace-group-replace-underscore-partial
branch
from
03a9ffc to
e4f6008
Compare
Tucchhaa
approved these changes
Mar 17, 2026
aleksei-semikozov
added a commit
to aleksei-semikozov/DevExtreme
that referenced
this pull request
Mar 17, 2026
…eline, month, indicator) (DevExpress#32797)
aleksei-semikozov
deleted the
3519-workspace-group-replace-underscore-partial
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.