Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize DataGrid keyboard navigation (KBN) e2e tests by ensuring the DataGrid instance is fully initialized before interactions and screenshot assertions occur.
Changes:
- Added a readiness assertion (
t.expect(dataGrid.isReady()).ok()) at the start of multiple keyboard navigation tests. - Applied the same stabilization step to both visual and functional keyboard navigation test suites.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/keyboardNavigation.visual.ts | Adds an explicit DataGrid readiness check before performing keyboard actions and taking screenshots. |
| e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/keyboardNavigation.functional.ts | Adds an explicit DataGrid readiness check before running functional keyboard-navigation assertions. |
Comment on lines
+16
to
+18
| await t | ||
| .expect(dataGrid.isReady()) | ||
| .ok(); |
Comment on lines
+31
to
+33
| await t | ||
| .expect(dataGrid.isReady()) | ||
| .ok(); |
anna-shakhova
approved these changes
Mar 19, 2026
Raushen
added a commit
to Raushen/DevExtreme
that referenced
this pull request
Mar 19, 2026
Raushen
added a commit
to Raushen/DevExtreme
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.