Splitter: save initial size for collapsed panels on initialization#33059
Merged
dmlvr merged 5 commits intoMar 30, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the internal Splitter sizing logic so panes that start collapsed (or hidden) with an explicit size remember that initial size and restore it when expanded/shown, rather than falling back to the default “expand to half” behavior.
Changes:
- Added initialization-time caching of pane sizes/directions for initially collapsed or invisible panes that have a defined
size. - Ensured pane size caches are reset early in
_initMarkupand initialized after computing the initial layout. - Added QUnit coverage for expand/show behavior when
collapsed/visibleis set on initialization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/splitter.tests.js | Adds new pane sizing tests verifying restoration to user-specified sizes for initially collapsed/hidden panes. |
| packages/devextreme/js/__internal/ui/splitter/splitter.ts | Introduces _initPanesCacheSize() and wires it into initial layout computation to preserve initial sizes for collapsed/hidden panes. |
EugeniyKiyashko
force-pushed
the
26_1_splitter_collapsed_cache
branch
from
1615485 to
1988d3c
Compare
pharret31
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.