TextEditorBase: Improve typing && Refactor#33081
Merged
marker-dao merged 3 commits intoMar 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving TypeScript typing and doing small refactors around the internal TextEditorBase implementation and related text editor/mask/button plumbing.
Changes:
- Adjusted typings for text editor buttons (
TextEditorButtonInfo.Ctor) and several editor event handler signatures. - Refactored parts of
TextEditorBaseto reducets-expect-errorusage and improve option destructuring / readability. - Updated mask/editor
_renderValuereturn typing and added ESLint suppressions for intentionally un-awaited calls.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/text_box/texteditor_button_collection/index.ts | Updates the constructor typing for button metadata (Ctor). |
| packages/devextreme/js/__internal/ui/text_box/text_editor.mask.ts | Removes DeferredObj typing usage and changes _renderValue signature; adds no-floating-promises suppressions. |
| packages/devextreme/js/__internal/ui/text_box/m_text_editor.base.ts | Main refactor/typing pass for TextEditorBase (events, options, _renderValue, clear handler typing, etc.). |
| packages/devextreme/js/__internal/ui/date_box/date_box.base.ts | Aligns _clearValueHandler typing with the updated base signature. |
| packages/devextreme/js/__internal/ui/chat/message_box/chat_text_area.ts | Aligns _keyPressHandler typing with updated base signature. |
marker-dao
force-pushed
the
26_1_text_editor_base_types
branch
from
88223d0 to
1db4aa1
Compare
r-farkhutdinov
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.