Scheduler - Fix TypeScript errors in appointment popup test mocks#33175
Open
aleksei-semikozov wants to merge 1 commit intoDevExpress:26_1from
Open
Scheduler - Fix TypeScript errors in appointment popup test mocks#33175aleksei-semikozov wants to merge 1 commit intoDevExpress:26_1from
aleksei-semikozov wants to merge 1 commit intoDevExpress:26_1from
Conversation
aleksei-semikozov
force-pushed
the
fix/scheduler-test-types-26_1
branch
from
d3bfea2 to
6700c19
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TypeScript typing issues in Scheduler appointment popup tests by tightening the typings of Jest mocks used for the onSave callback and related test helpers.
Changes:
- Typed
addAppointmentandonSavemocks inappointment_popup.test.tsto avoid implicit/incorrect inference. - Updated
create_appointment_popuptest helper types soonSaveis consistently a promise-returning mock with a typed appointment parameter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts |
Adds explicit generic/parameter types to Jest mocks used in the composite onSave scenario. |
packages/devextreme/js/__internal/scheduler/__tests__/__mock__/create_appointment_popup.ts |
Narrows onSave option/return callback typings and types the default jest.fn implementation to match AppointmentPopupConfig.onSave. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.