Skip to content

Scheduler - Unskip testcafe tests #33200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tucchhaa merged 3 commits into from
Apr 9, 2026
+5 −6
Merged

Scheduler - Unskip testcafe tests #33200

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
756b2e1
unskip tests
Tucchhaa Apr 8, 2026
aa79e23
fix test
Tucchhaa Apr 9, 2026
af79851
apply copilot review
Tucchhaa Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/testcafe-devextreme/tests/scheduler/common/layout/customization/cellSizesCss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const HORIZONTAL_VIEW_CROSS_SCROLLING_CASES = {
HORIZONTAL_VIEW_CROSS_SCROLLING_CASES,
].forEach(({ views, expect, crossScrollingEnabled }) => {
views.forEach((view) => {
test.skip(
test(
Copy link
Copy Markdown
Contributor Author

@Tucchhaa Tucchhaa Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the history:
https://github.com/Tucchhaa/DevExtreme/blame/b7f2e313133634034b38ecba8b20f81a76fed120/e2e/testcafe-devextreme/tests/scheduler/common/layout/customization/cellSizesCss.ts#L98

This test was skipped from the moment it was added, looks like it was an accident, so I just unskipped it

`Cells should have correct sizes and css classes (view:${view}, crossScrolling:${crossScrollingEnabled})`,
async (t) => {
const scheduler = new Scheduler(SELECTOR);
Expand Down
8 changes: 3 additions & 5 deletions e2e/testcafe-devextreme/tests/scheduler/common/virtualScrolling/appointments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,23 @@ import { scrollToDate } from '../../helpers/utils';
fixture.disablePageReloads`Scheduler: Virtual Scrolling`
.page(url(__dirname, '../../../container.html'));

test.skip('Appointment should not repaint after scrolling if present on viewport', async (t) => {
test('Appointment should not repaint after scrolling if present on viewport', async (t) => {
const scheduler = new Scheduler('#container');
const { element } = scheduler.getAppointment('', 0);

await setStyleAttribute(element, 'background-color: red;');
Copy link
Copy Markdown
Contributor Author

@Tucchhaa Tucchhaa Apr 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This background-color is set here just to check if the value of the style attr hasn't changed (if appt is rerendered then style attr value will reset)

await t.expect(await getStyleAttribute(element)).eql('transform: translate(525px, 200px); width: 49px; height: 100px; background-color: red;');
const initialStyle = await getStyleAttribute(element);

await scrollToDate(new Date(2020, 8, 17, 4));
Comment thread
Tucchhaa marked this conversation as resolved.

await t.expect(await getStyleAttribute(element)).eql('transform: translate(525px, 200px); width: 49px; height: 100px; background-color: red;');
await t.expect(await getStyleAttribute(element)).eql(initialStyle);
}).before(async () => {
await createWidget('dxScheduler', {
height: 600,
width: 800,
currentDate: new Date(2020, 8, 7),
scrolling: {
mode: 'virtual',
orientation: 'both',
Copy link
Copy Markdown
Contributor Author

@Tucchhaa Tucchhaa Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Private option, I removed it, because the default value is also 'both':

DevExtreme/packages/devextreme/js/__internal/scheduler/workspaces/m_virtual_scrolling.ts

Line 21 in aa79e23

const DefaultScrollingOrientation = scrollingOrientations.both;

outlineCount: 0,
Copy link
Copy Markdown
Contributor Author

@Tucchhaa Tucchhaa Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Private option. This option determines how many rows or columns to render outside the viewport if virtual scrolling is enabled. It's redundant in the case of this test, because appointment is always in the viewport (on init and after scroll)

},
currentView: 'week',
views: [{
Expand Down
Loading