AIChat: popup and chat default configuration#33225
Open
anna-shakhova wants to merge 5 commits intoDevExpress:26_1from
Open
AIChat: popup and chat default configuration#33225anna-shakhova wants to merge 5 commits intoDevExpress:26_1from
anna-shakhova wants to merge 5 commits intoDevExpress:26_1from
Conversation
cd8e2d2 to
ccf3cce
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the DataGrid AI Assistant integration by introducing default Popup/Chat configuration, exposing additional styling hooks for the Chat empty view, and wiring option-change handling so aiAssistant.popup / aiAssistant.chat updates can be applied at runtime.
Changes:
- Export Chat MessageList empty-view CSS class constants and use them to build a localized empty view template in
AIChat. - Add default Popup/Chat options (including a clear-chat toolbar button) and support updating Popup/Chat options via
AIChat.updateOptions. - Introduce
aiAssistantoption-change helpers + Jest tests, and update AI Assistant view/controller logic to react to option changes.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/chat/messagelist.ts | Exports empty-view CSS class constants for reuse by AI Chat integration. |
| packages/devextreme/js/__internal/grids/grid_core/m_types.ts | Extends aiAssistant options typing with popup/chat option bags. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/types.ts | Simplifies AIChatOptions to rely on popupOptions/chatOptions rather than bespoke callbacks. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/const.ts | Introduces default Popup/Chat options and the clear-chat icon constant. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.ts | Builds default chat config (empty view template), adds clear button, and supports option updates. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.test.ts | Updates/extends tests for clear button presence and updateOptions behavior. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/utils.ts | Adds helpers to detect which aiAssistant.* options changed. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/const.ts | Adds AI Assistant popup offset constant. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts | Creates Popup/Chat option objects, message store, and handles aiAssistant option changes. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view_controller.ts | Syncs toolbar item and active state based on AI Assistant visibility and option changes. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/utils.test.ts | Adds Jest coverage for option-change helper predicates. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view.test.ts | Updates tests for new Popup/Chat config wiring and optionChanged behavior. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view_controller.test.ts | Updates tests for subscription behavior and enabled/title option handling. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view_controller.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view_controller.ts
Show resolved
Hide resolved
1bc3374 to
bfffd55
Compare
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/base/gridBase/layout/ai-chat/_mixins.scss
Outdated
Show resolved
Hide resolved
b84ac8b to
e3e72b8
Compare
e3e72b8 to
b643745
Compare
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/material/gridBase/_index.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/generic/gridBase/_index.scss
Outdated
Show resolved
Hide resolved
packages/devextreme-scss/scss/widgets/fluent/gridBase/_index.scss
Outdated
Show resolved
Hide resolved
b643745 to
afc9abe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.