Scheduler - A11y - Don't hide tooltip on item delete#33352
Open
Tucchhaa wants to merge 5 commits intoDevExpress:26_1from
Open
Scheduler - A11y - Don't hide tooltip on item delete#33352Tucchhaa wants to merge 5 commits intoDevExpress:26_1from
Tucchhaa wants to merge 5 commits intoDevExpress:26_1from
Conversation
Tucchhaa
commented
Apr 21, 2026
| assert.equal(scheduler.tooltip.getDateText(), 'February 9 11:00 AM - 12:00 PM', 'dates and time were displayed correctly'); | ||
| }); | ||
|
|
||
| test('Click on tooltip-remove button should call scheduler.deleteAppointment and hide tooltip', async function(assert) { |
Contributor
Author
There was a problem hiding this comment.
Removed this test, because there is a new jest test covering this case
Tucchhaa
commented
Apr 21, 2026
| assert.notOk(scheduler.tooltip.isVisible(), 'tooltip was hidden'); | ||
| }); | ||
|
|
||
| test('Click on tooltip-remove button should call scheduler.updateAppointment and hide tooltip, if recurrenceRuleExpr and recurrenceExceptionExpr is set', async function(assert) { |
Contributor
Author
There was a problem hiding this comment.
Removed this test, because there is a new jest test covering this case
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Scheduler appointment tooltip behavior (including compact/collector tooltips) so that deleting an item does not automatically hide the tooltip, improving keyboard/a11y workflows and reducing disruptive UI changes.
Changes:
- Stop hiding the tooltip on delete actions (mouse and keyboard) and update tooltip contents in-place when collector items change.
- Extend the appointment view-model diffing to support an “update items” operation (vs remove+add) to avoid unnecessary re-renders.
- Update unit/integration/e2e tests and mocks to reflect the new tooltip lifecycle and rendering behavior.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.appointmentTooltip.tests.js | Updates integration expectations: collector tooltip stays visible until last item removed; tooltip updates after dataSource changes. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.adaptivity.tests.js | Adjusts mobile tooltip test to expect tooltip to remain visible after delete. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/desktopTooltip.tests.js | Updates desktop tooltip tests for new List options and new API name (isShownForTarget). |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/common.methods.tests.js | Updates scheduler method tests to use isShownForTarget. |
| packages/devextreme/js/__internal/scheduler/tooltip_strategies/m_tooltip_strategy_base.ts | Adds tooltip target/list update helpers; removes hide-on-delete; adds repaintChangesOnly; renames isAlreadyShown → isShownForTarget. |
| packages/devextreme/js/__internal/scheduler/m_scheduler.ts | Wires tooltip strategy earlier and injects appointmentTooltip into appointments options; uses isShownForTarget. |
| packages/devextreme/js/__internal/scheduler/appointments/utils/get_view_model_diff.ts | Refactors diffing to support a dedicated “update items” change type. |
| packages/devextreme/js/__internal/scheduler/appointments/utils/get_arrays_diff.ts | Adds needToUpdateItems diff operation and expands diff API (match/equal/itemsLengthEqual). |
| packages/devextreme/js/__internal/scheduler/appointments/utils/get_arrays_diff.test.ts | Updates and expands Jest coverage for the new diff behavior and flags. |
| packages/devextreme/js/__internal/scheduler/appointments/m_appointment_collection.ts | Implements tooltip-aware remove/update flows and reuses compact-appointment item mapping. |
| packages/devextreme/js/__internal/scheduler/tests/appointment_tooltip.test.ts | Expands Jest tests for delete behavior, collector tooltip persistence, and tooltip target stability. |
| packages/devextreme/js/__internal/scheduler/tests/mock/model/tooltip.ts | Adds accessors for tooltip instance/target and improves delete button querying. |
| packages/devextreme/js/__internal/scheduler/tests/mock/m_mock_scheduler.ts | Adds getClientRects mocking to support tooltip list navigation sizing. |
| e2e/testcafe-devextreme/tests/scheduler/common/recurrences/etalons/recurrence-delete-dialog-screenshot (fluent.blue.light).png | Updates screenshot baseline for recurrence delete dialog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.