DateBox: Fix validation message not cleared when masked date returns to valid range (T1326750)#33356
Merged
r-farkhutdinov merged 2 commits intoDevExpress:26_1from Apr 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a DateBox mask-validation edge case where an internal (editor-specific) validation error could persist after the user returns the masked date back into the allowed min/max range.
Changes:
- Added a regression test that reproduces the “out of range → back in range” scenario for masked date editing (T1326750).
- Updated
DateBoxMask._fireChangeEvent()to also trigger achangeevent when the editor is currently invalid due to an editor-specific validation error, even if the underlying value is not “dirty”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.mask.tests.js | Adds a regression test covering validity toggling when changing a masked date out of range and back. |
| packages/devextreme/js/__internal/ui/date_box/date_box.mask.ts | Ensures change is fired to re-run internal validation when isValid=false with validationError.editorSpecific, even if the value hasn’t changed. |
…to valid range (T1326750)
r-farkhutdinov
force-pushed
the
26_1_T1326750
branch
from
df63765 to
43c3d63
Compare
marker-dao
previously approved these changes
Apr 20, 2026
marker-dao
approved these changes
Apr 20, 2026
r-farkhutdinov
added a commit
to r-farkhutdinov/DevExtreme
that referenced
this pull request
Apr 20, 2026
…to valid range (T1326750) (DevExpress#33356) Co-authored-by: Ruslan Farkhutdinov <ruslan.farkhutdinov@devexpress.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.