Skip to content

DateBox: Fix validation message not cleared when masked date returns to valid range (T1326750) #33359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r-farkhutdinov merged 1 commit into from
Apr 20, 2026
+35 −1
Merged

DateBox: Fix validation message not cleared when masked date returns to valid range (T1326750) #33359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/devextreme/js/__internal/ui/date_box/date_box.mask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,10 +705,16 @@ class DateBoxMask extends DateBoxBase {
return this._maskValue?.getTime() !== value?.getTime();
}

_hasEditorSpecificValidationError(): boolean {
const { isValid, validationError } = this.option();

return !isValid && Boolean(validationError?.editorSpecific);
}

_fireChangeEvent(): void {
this._clearSearchValue();

if (this._isValueDirty()) {
if (this._isValueDirty() || this._hasEditorSpecificValidationError()) {
eventsEngine.triggerHandler(this._input(), { type: 'change' });
}
}
Expand Down
28 changes: 28 additions & 0 deletions packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.mask.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,6 +1672,34 @@ module('Regression', () => {

assert.strictEqual($input.val(), '12:34', 'both digits go to hours and minutes stay unchanged');
});

QUnit.test('should be valid when date returns to valid range after out-of-range change (T1326750)', function(assert) {
const $dateBox = $('#dateBox').dxDateBox({
useMaskBehavior: true,
pickerType: 'calendar',
type: 'date',
displayFormat: 'dd-MM-yyyy',
value: new Date(2020, 2, 31),
min: new Date(2018, 3, 1),
max: new Date(2020, 2, 31),
});

const instance = $dateBox.dxDateBox('instance');
const $input = $dateBox.find(`.${TEXT_EDITOR_INPUT_CLASS}`);
const keyboard = keyboardMock($input, true);

keyboard.press('right').press('right');

keyboard.press('up');
keyboard.press('enter');

assert.strictEqual(instance.option('isValid'), false, 'should be invalid when year 2021 exceeds max date');

keyboard.press('down');
keyboard.press('enter');

assert.strictEqual(instance.option('isValid'), true, 'should be valid when year returns to 2020');
});
});

module('Caret moving', setupModule, () => {
Expand Down
Loading