DateBox: Use localized day period names (T1327076)#33365
Merged
marker-dao merged 2 commits intoDevExpress:26_1from Apr 22, 2026
Merged
DateBox: Use localized day period names (T1327076)#33365marker-dao merged 2 commits intoDevExpress:26_1from
marker-dao merged 2 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DateBox mask AM/PM handling to use localized day period (AM/PM) names, and adds a regression test to ensure keyboard arrow toggling continues to work in locales where period names differ from "AM"/"PM".
Changes:
- Updated
DateBoxMask._toggleAmPmto determine the current AM/PM index using localized period names. - Added a QUnit test that switches locale to
es-ESand verifies repeateduppresses keep toggling between localized AM/PM. - Minor readability refactors (local variables / whitespace) in the mask implementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/devextreme/js/__internal/ui/date_box/date_box.mask.ts |
Switches AM/PM toggle lookup from hardcoded default names to localized period names. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.mask.tests.js |
Adds regression coverage for repeated AM/PM toggling under a locale with localized period strings. |
marker-dao
force-pushed
the
26_1_T1327076_datebox_es_locale
branch
from
e258664 to
d289845
Compare
r-farkhutdinov
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.