chore(devextreme): migrate build:vectormap target to nx executors#33368
Open
chaosmirage wants to merge 9 commits into26_1from
Open
chore(devextreme): migrate build:vectormap target to nx executors#33368chaosmirage wants to merge 9 commits into26_1from
build:vectormap target to nx executors#33368chaosmirage wants to merge 9 commits into26_1from
Conversation
chaosmirage
force-pushed
the
chore/migrate-devextreme-to-nx-part-7
branch
from
833ab43 to
c4e3970
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the DevExtreme-to-Nx migration by replacing the Gulp-based vectormap build pipeline with dedicated Nx Infra Plugin executors, and introducing a reusable compress executor to minify/beautify JS outputs as part of the Nx build graph.
Changes:
- Added
vectormapexecutor to generate vectormap utility bundles and region data modules from sources/templates. - Added
compressexecutor (minify/beautify + optional#DEBUGstripping) and wired it intodevextreme’s vectormap production build. - Removed the legacy
build/gulp/vectormap.jstask and routed thegulp vectormapentrypoint to Nx targets.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile updates reflecting new dependencies and resolution changes. |
| packages/nx-infra-plugin/src/utils/file-operations.ts | Adds EOL normalization + trailing newline helpers used by new executors. |
| packages/nx-infra-plugin/src/executors/vectormap/schema.ts | TypeScript schema for the new vectormap executor options. |
| packages/nx-infra-plugin/src/executors/vectormap/schema.json | JSON schema for vectormap executor configuration. |
| packages/nx-infra-plugin/src/executors/vectormap/executor.ts | Implements vectormap utils bundling + data generation workflow. |
| packages/nx-infra-plugin/src/executors/vectormap/executor.e2e.spec.ts | E2E coverage for vectormap generation. |
| packages/nx-infra-plugin/src/executors/compress/schema.ts | TypeScript schema for the new compress executor options. |
| packages/nx-infra-plugin/src/executors/compress/schema.json | JSON schema for compress executor configuration. |
| packages/nx-infra-plugin/src/executors/compress/executor.ts | Implements minify/beautify + debug stripping using terser/js-beautify. |
| packages/nx-infra-plugin/src/executors/compress/executor.e2e.spec.ts | E2E coverage for compression behaviors and license preservation. |
| packages/nx-infra-plugin/package.json | Adds terser and js-beautify dependencies for the compress executor. |
| packages/nx-infra-plugin/executors.json | Registers the new vectormap and compress executors. |
| packages/devextreme/project.json | Replaces gulp vectormap run-command with Nx vectormap pipeline (generate/headers/compress). |
| packages/devextreme/gulpfile.js | Removes old vectormap gulp include and forwards gulp vectormap to Nx targets. |
| packages/devextreme/build/gulp/vectormap.js | Removes the legacy vectormap gulp implementation. |
| .github/copilot-instructions.md | Documents the new build:vectormap target and executors. |
chaosmirage
changed the title
build:vectormap target to nx executors
chaosmirage
force-pushed
the
chore/migrate-devextreme-to-nx-part-7
branch
from
bc9e058 to
00117e8
Compare
chaosmirage
force-pushed
the
chore/migrate-devextreme-to-nx-part-7
branch
from
00117e8 to
f54034a
Compare
- normalizeEol: also replace standalone CR (\r) for full EOL coverage - vectormap buildData: add ensureTrailingNewline for consistency with buildUtilsVariant - compress: fail loudly when terser produces no output instead of silently returning uncompressed content
chaosmirage
force-pushed
the
chore/migrate-devextreme-to-nx-part-7
branch
from
f54034a to
6502e7d
Compare
mpreyskurantov
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.