Skip to content

Fix the remaining audit alerts#33370

Merged
alexslavr merged 10 commits into
24_1from
lavrov/audit-alerts-2-24_1
Apr 22, 2026
Merged

Fix the remaining audit alerts#33370
alexslavr merged 10 commits into
24_1from
lavrov/audit-alerts-2-24_1

Conversation

@alexslavr
Copy link
Copy Markdown
Contributor

Use deterministic npm ci and npx --no-install

@alexslavr alexslavr self-assigned this Apr 21, 2026
@alexslavr alexslavr requested a review from a team as a code owner April 21, 2026 12:52
@alexslavr alexslavr added the 24_1 label Apr 21, 2026
@alexslavr alexslavr requested a review from Copilot April 21, 2026 13:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI and tooling to reduce audit-related variability by using deterministic dependency installs (npm ci) and preventing npx from auto-installing packages (npx --no-install).

Changes:

  • Switched several GitHub Actions steps from npm install to npm ci.
  • Updated workflows/actions to use npx --no-install for existing tooling.
  • Removed an npm i --legacy-peer-deps call from the version bump script.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tools/scripts/overwrite-wrappers-packages.ts Updates user-facing script instructions (console output).
tools/scripts/common/version.ts Adjusts version bump behavior by removing a post-bump install step.
.github/workflows/themebuilder_tests.yml Uses npx --no-install for gulp/nx/stylelint in CI.
.github/workflows/packages_publishing.yml Uses npx --no-install and switches install step to npm ci.
.github/workflows/demos_visual_tests_frameworks.yml Switches a tarball install step to npm ci.
.github/actions/setup-chrome-headless-shell/action.yml Changes how chrome-headless-shell is installed via npx.
.github/actions/run-qunit-tests/action.yml Reorders setup-node/cache/npm-ci steps for QUnit runs.

Comment thread tools/scripts/overwrite-wrappers-packages.ts Outdated
Comment thread tools/scripts/common/version.ts
Comment thread .github/workflows/demos_visual_tests_frameworks.yml
Comment thread .github/actions/setup-chrome-headless-shell/action.yml Outdated
Comment thread .github/workflows/packages_publishing.yml
@alexslavr alexslavr force-pushed the lavrov/audit-alerts-2-24_1 branch from babc1b2 to 16c1a65 Compare April 22, 2026 13:36
@alexslavr alexslavr force-pushed the lavrov/audit-alerts-2-24_1 branch from af2dfe7 to 55d0ef5 Compare April 22, 2026 14:20
@alexslavr alexslavr merged commit 7064f69 into 24_1 Apr 22, 2026
67 checks passed
@alexslavr alexslavr deleted the lavrov/audit-alerts-2-24_1 branch April 22, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants