DataGrid - Pager - Show correct pageIndex when virtualScrolling is enabled on pageSize change by Tucchhaa · Pull Request #33412 · DevExpress/DevExtreme

Tucchhaa · 2026-04-27T08:57:46Z

No description provided.

Copilot

Pull request overview

Fixes DataGrid pager’s displayed page index when switching the page size to “all” (internally pageSize = 0) while virtual scrolling is enabled, ensuring the pager info shows a valid “Page 1 of 1 …” state.

Changes:

Adjust pager page index calculation to handle pageSize === 0 (the “all items” mode).
Add a TestCafe e2e regression test covering the virtual-scrolling + pageSize “all” scenario.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
packages/devextreme/js/__internal/grids/grid_core/pager/m_pager.ts	Ensures pager’s 1-based `pageIndex` is correct when `pageSize` is set to 0 (“all”).
e2e/testcafe-devextreme/tests/dataGrid/common/pager.ts	Adds regression test verifying pager info becomes “Page 1 of 1 …” after switching to “all” with virtual scrolling.

anna-shakhova · 2026-04-29T11:11:15Z

 export const MAX_PAGES_COUNT = 10;

 const getPageIndex = function (dataController) {
+  if (dataController.pageSize() === 0) {


This lines may confuse later, I think it should be fixed on pageIndex level instead
like changePaging in data controller resets pageIndex to 0 in case of pageSize = 0, same should be here, also you may notice that after changing to pageSize = All grid shows 1st page (rows from 1), not keeps the prev one

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Tucchhaa · 2026-05-08T06:46:33Z

@@ -671,7 +671,7 @@ QUnit.module('Real DataController and ColumnsController', {
        this.cellValue(0, 2, '5');
        this.saveEditData();
        // assert
-        assert.equal(focusedRowChangedFiresCount, 2, 'onFocusedRowChanged fires count');


Name of the test suggest that focusedRowChangedFiresCount should increase after refresh, but current test doesn't check it.

Initial test did it, though: link

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts:57

When setting pageIndex/pageSize, changePaging now returns an already-resolved Deferred instead of returning the dataSource.load()/reload() Deferred. This breaks the existing contract where callers can chain .done(items => ...) and receive the loaded items after paging completes (see existing tests like testing/tests/DevExpress.ui.widgets.dataGrid/dataController.tests.js that assert the loaded items in the .done callback). Please restore returning the actual load/reload promise (and its resolved items) while still fixing the pageIndex reset behavior for pageSize changes.

      return Deferred().resolve().promise();
    }
    return dataSource[optionName]();
  }

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

+  onOptionChanged: (e) => {
+    if (e.fullName === 'paging.pageSize') {
+      const setVirtual = e.value === 0;
+      const targetRenderingMode = setVirtual ? 'virtual' : 'standard';
+      const currentRenderingMode = e.component.option('scrolling.mode');
+      if (currentRenderingMode !== targetRenderingMode) {
+        e.component.beginUpdate();
+        e.component.option('scrolling.mode', targetRenderingMode);
+        e.component.repaint();
+        e.component.endUpdate();
+      }
+    }
+  },


anna-shakhova · 2026-06-01T13:41:36Z

-      change.needUpdateDimensions = change.needUpdateDimensions || that._needUpdateDimensions;
+    if (this._repaintChangesOnly !== undefined) {
+      change.repaintChangesOnly ??= this._repaintChangesOnly;
+      change.needUpdateDimensions ??= this._needUpdateDimensions;


This is not the same as previous version, now we override undefined only, before we also update value for false

anna-shakhova · 2026-06-01T13:42:53Z

-        change.needUpdateDimensions = true;
-      }
+      change.repaintChangesOnly = operationTypes && !operationTypes.grouping && !operationTypes.filtering && this.option('repaintChangesOnly');
+      change.needUpdateDimensions = operationTypes && (operationTypes.reload || operationTypes.paging || operationTypes.groupExpanding);


Let's keep prev version, it was easier for reading, also we changes logic a bit: now it unconditionally assigns true/false/undefined whereas before it left a pre-existing value alone when the condition was false.

anna-shakhova · 2026-06-01T13:52:25Z

        that._skipProcessingPagingChange = true;
+
+        if (optionName === 'pageSize') {
+          that.option('paging.pageIndex', 0);


Is there any reason to update paging.pageIndex not in the same moment as dataSource.pageIndex? If not, let's combine them in single condition for readability

combined, but had to update one qunit test:

DevExtreme/packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/dataController.tests.js

Line 3227 in cf17123

QUnit.test('Change pageSize', function(assert) {

Because it checked that pageIndex should be 0, but since we decided to keep the pageIndex between finite pageSize changes, the test is not actual anymore

anna-shakhova · 2026-06-01T14:51:17Z


        that._skipProcessingPagingChange = true;
+
+        if (optionName === 'pageSize') {


Please, add here condition: && value === 0 to reset page index only for 'All' case

This reverts commit 07a49c2.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

This reverts commit b676939.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Tucchhaa self-assigned this Apr 27, 2026

Tucchhaa added cherry-pick 26_1 labels Apr 27, 2026

fix

664a129

Tucchhaa force-pushed the fix_grid_pager_26_1 branch from 0b6a17d to 664a129 Compare April 27, 2026 10:05

implement test

29f7c02

Tucchhaa marked this pull request as ready for review April 28, 2026 10:37

Copilot AI review requested due to automatic review settings April 28, 2026 10:37

Tucchhaa requested a review from a team as a code owner April 28, 2026 10:37

Copilot started reviewing on behalf of Tucchhaa April 28, 2026 10:37 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

Tucchhaa commented Apr 28, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/pager/m_pager.ts

Tucchhaa removed the cherry-pick label Apr 28, 2026

anna-shakhova reviewed Apr 29, 2026

View reviewed changes

anna-shakhova requested changes Apr 29, 2026

View reviewed changes

Tucchhaa force-pushed the fix_grid_pager_26_1 branch from f4a744f to 09c0b62 Compare May 6, 2026 10:25

Copilot AI review requested due to automatic review settings May 6, 2026 10:25

Copilot started reviewing on behalf of Tucchhaa May 6, 2026 10:26 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 8, 2026 05:12

Copilot started reviewing on behalf of Tucchhaa May 8, 2026 05:13 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts

Copilot AI review requested due to automatic review settings May 8, 2026 06:41

Copilot started reviewing on behalf of Tucchhaa May 8, 2026 06:42 View session

Tucchhaa commented May 8, 2026

View reviewed changes

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts Outdated

Copilot AI review requested due to automatic review settings May 8, 2026 07:23

Copilot started reviewing on behalf of Tucchhaa May 8, 2026 07:24 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread e2e/testcafe-devextreme/tests/dataGrid/common/pager.ts Outdated

refix

eb5a17d

Copilot AI review requested due to automatic review settings May 20, 2026 09:14

Copilot started reviewing on behalf of Tucchhaa May 20, 2026 09:14 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts Outdated

Copilot AI review requested due to automatic review settings May 22, 2026 08:15

Copilot started reviewing on behalf of Tucchhaa May 22, 2026 08:15 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts Outdated

Comment thread e2e/testcafe-devextreme/tests/dataGrid/common/pager.ts

Comment thread e2e/testcafe-devextreme/tests/dataGrid/common/pager.ts

Copilot AI review requested due to automatic review settings May 22, 2026 11:17

Copilot started reviewing on behalf of Tucchhaa May 22, 2026 11:17 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

remove pageIndex restoration

07a49c2

Tucchhaa force-pushed the fix_grid_pager_26_1 branch from 15682ba to 07a49c2 Compare May 22, 2026 11:59

anna-shakhova reviewed Jun 1, 2026

View reviewed changes

Tucchhaa added 2 commits June 3, 2026 14:39

Revert "remove pageIndex restoration"

bae0af6

This reverts commit 07a49c2.

apply review

fd35838

Copilot AI review requested due to automatic review settings June 3, 2026 06:48

Copilot started reviewing on behalf of Tucchhaa June 3, 2026 06:48 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts

Comment thread packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts

fix test

cf17123

anna-shakhova previously approved these changes Jun 3, 2026

View reviewed changes

AI Assistant: add filter value to command default message

b676939

Copilot AI review requested due to automatic review settings June 3, 2026 10:45

anna-shakhova dismissed their stale review via b676939 June 3, 2026 10:45

Copilot started reviewing on behalf of anna-shakhova June 3, 2026 10:45 View session

Revert "AI Assistant: add filter value to command default message"

308acc5

This reverts commit b676939.

anna-shakhova approved these changes Jun 3, 2026

View reviewed changes

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Tucchhaa merged commit 851f460 into DevExpress:26_1 Jun 4, 2026
107 of 108 checks passed

Tucchhaa deleted the fix_grid_pager_26_1 branch June 4, 2026 06:07


		that._skipProcessingPagingChange = true;

		if (optionName === 'pageSize') {

Uh oh!

Conversation

Tucchhaa commented Apr 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees