MenuBase: disabled items should have the correct cursor (T1327513)#33415
Merged
pharret31 merged 6 commits intoDevExpress:26_1from Apr 27, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MenuBase styling so disabled menu items use the correct cursor, and adds QUnit coverage for the expected cursor behavior (T1327513).
Changes:
- Adjusts
_menuBase.scssto applycursor: pointeron.dx-menu-itemandcursor: defaulton disabled items. - Adds QUnit tests validating cursor style for enabled, disabled, and runtime-disabled menu items.
- Loads Fluent theme CSS in the MenuBase test file so cursor styles are available in test runs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/menuBase.tests.js | Adds cursor-style QUnit tests and imports Fluent theme CSS for style assertions. |
| packages/devextreme-scss/scss/widgets/base/_menuBase.scss | Moves pointer cursor styling to .dx-menu-item and overrides it for disabled items. |
dmlvr
previously approved these changes
Apr 27, 2026
dmlvr
previously approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MenuBase styling and tests to ensure disabled menu items show the correct mouse cursor, aligning UI behavior with ticket T1327513.
Changes:
- Adjusted MenuBase base SCSS to apply
cursor: pointeron menu items andcursor: defaultfor disabled states. - Added QUnit coverage for cursor behavior on enabled/disabled items and for menus disabled via the
disabledoption. - Loaded Fluent theme CSS in the MenuBase test suite to make computed cursor assertions reliable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets/menuBase.tests.js | Adds QUnit tests validating cursor style for enabled vs disabled menu items (including runtime disable). |
| packages/devextreme-scss/scss/widgets/base/_menuBase.scss | Moves pointer cursor styling to .dx-menu-item and adds disabled-state cursor overrides; sets default cursor on submenu container. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a UI styling issue in MenuBase where disabled menu items should display the correct mouse cursor, and adds regression tests to validate cursor behavior.
Changes:
- Added QUnit coverage for cursor style on enabled/disabled MenuBase items (including runtime disabling and menu-level disabling).
- Updated base MenuBase SCSS to apply
cursor: pointeron menu items andcursor: defaultfor disabled states, plus default cursor for submenu containers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets/menuBase.tests.js |
Adds cursor-style regression tests (and imports Fluent theme CSS for style assertions). |
packages/devextreme-scss/scss/widgets/base/_menuBase.scss |
Moves pointer cursor to .dx-menu-item, sets default cursor for disabled menu items, and sets submenu cursor to default. |
EugeniyKiyashko
previously approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses T1327513 by ensuring disabled MenuBase items display the correct mouse cursor (default arrow instead of pointer), aligning MenuBase cursor behavior with disabled state expectations across themes.
Changes:
- Updated MenuBase base SCSS so the
pointercursor is applied to.dx-menu-item(not the items container), and disabled states forcecursor: default. - Added QUnit markup tests covering cursor behavior for enabled items, disabled items, runtime disabling, fully-disabled menus, and URL items.
- Ensured the Fluent theme stylesheet is loaded for the new style-based assertions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets/menuBase.markup.tests.js |
Adds regression tests validating cursor styles for enabled/disabled MenuBase items (incl. runtime changes). |
packages/devextreme-scss/scss/widgets/base/_menuBase.scss |
Moves cursor: pointer to .dx-menu-item, adds disabled-state cursor overrides, and sets submenu container cursor to default. |
EugeniyKiyashko
approved these changes
Apr 27, 2026
This was referenced Apr 27, 2026
pharret31
deleted the
26_1_4050-t1327513---menu---disabled-menu-items-have-the-pointer-cursor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.