Scheduler: T1327394 — fix appointments display for DST#33416
Open
sjbur wants to merge 2 commits intoDevExpress:26_1from
Open
Scheduler: T1327394 — fix appointments display for DST#33416sjbur wants to merge 2 commits intoDevExpress:26_1from
sjbur wants to merge 2 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Scheduler timeline/week cell generation around “midnight DST” (where local 00:00 is skipped, e.g. Africa/Cairo), preventing an extra leading cell and ensuring subsequent appointment placement aligns with the first reachable local time.
Changes:
- Added Cairo timezone regression tests for
getWeekIntervalscovering midnight DST behavior. - Updated
getMinutesCellIntervalsto start day cell generation from the first reachable local time on midnight DST days. - Exposed a new timezone utility helper to adjust day-interval minimums for midnight DST.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/view_model/generate_view_model/options/get_week_intervals.cairo.test.ts | Adds regression coverage for Cairo midnight DST so timeline/week doesn’t generate an unreachable 00:00 cell. |
| packages/devextreme/js/__internal/scheduler/view_model/generate_view_model/options/get_minutes_cell_intervals.ts | Adjusts per-day cell start time to skip unreachable midnight on midnight DST days. |
| packages/devextreme/js/__internal/scheduler/m_utils_time_zone.ts | Adds adjustDayIntervalMinForMidnightDST helper and exports it via timezone utils. |
Comment on lines
+265
to
+269
| const date = createDateFromUTCWithLocalOffset(new Date(dayIntervalMin)); | ||
| const isMidnightDST = startDayHour === 0 && isLocalTimeMidnightDST(date); | ||
|
|
||
| return isMidnightDST | ||
| ? dayIntervalMin + date.getHours() * 60 * 60 * 1000 |
aleksei-semikozov
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.