License: Remove expired trial handling#33424
Merged
ajivanyandev merged 2 commits intoDevExpress:26_1from Apr 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes “expired trial” detection and messaging from DevExtreme’s license tooling and runtime warning output paths, aligning behavior toward treating these cases as generic license verification failures.
Changes:
- Removed
trialExpiredwarning/template from thedevextreme-licenseCLI messages and output logic. - Removed
trial-expiredtoken-to-warning mapping from runtime license validation/warnings. - Removed expired-trial detection branch from the JS LCP parser used by the CLI conversion logic.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/license/messages.js | Drops trialExpired warning code/template text. |
| packages/devextreme/license/dx-lcx-2-lcp.js | Removes expired-trial classification during LCP parsing. |
| packages/devextreme/license/devextreme-license.js | Simplifies CLI warning output; no longer adds purchase line specifically for expired trial. |
| packages/devextreme/js/__internal/core/license/license_warnings.ts | Removes the trial-expired warning rendering branch. |
| packages/devextreme/js/__internal/core/license/license_validation.ts | Stops mapping trial-expired token to W0020 / trial-expired warning type. |
Comments suppressed due to low confidence (3)
packages/devextreme/js/__internal/core/license/license_warnings.ts:112
- With the 'trial-expired' switch case removed, logLicenseWarning no longer has explicit handling for the 'trial-expired' LicenseWarningType (still present in the type union). If any future call site passes 'trial-expired', the function will only log the purchase line and omit context. Either remove 'trial-expired' from LicenseWarningType or keep an explicit branch here to ensure consistent output.
case 'no-devextreme-license':
// Only the purchase line, no additional details
break;
default:
packages/devextreme/license/dx-lcx-2-lcp.js:224
- After removing the trial-expired branch in parseLCP, this JS implementation no longer matches the TS validator (lcp_key_validator.ts still returns a 'trial-expired' token for expired trial-only keys). Please either remove the trial-expired classification in the TS parser/types/tests as well, or restore equivalent logic here so devextreme-license and runtime validation stay consistent.
const maxVersionAllowed = findLatestDevExtremeVersion(products);
if(!maxVersionAllowed) {
return { ...PRODUCT_KIND_ERROR, licenseId };
}
packages/devextreme/license/dx-lcx-2-lcp.js:224
- Removing the trial-expired check makes getMaxExpiration() unused in this file (only definition remains). If eslint/no-unused-vars is enabled for the license tool, this will fail lint; please delete getMaxExpiration (and any now-dead helpers) or reintroduce a caller.
const maxVersionAllowed = findLatestDevExtremeVersion(products);
if(!maxVersionAllowed) {
return { ...PRODUCT_KIND_ERROR, licenseId };
}
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
packages/devextreme/license/dx-lcx-2-lcp.js:224
getMaxExpirationis now unused after removing the trial-expired branch. Sinceno-unused-varsis enforced in this package, this leftover helper will trigger lint errors—please remove it (and any now-dead constants/logic tied to it) fromdx-lcx-2-lcp.js.
const maxVersionAllowed = findLatestDevExtremeVersion(products);
if(!maxVersionAllowed) {
return { ...PRODUCT_KIND_ERROR, licenseId };
}
GoodDayForSurf
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.