Skip to content

License: Remove expired trial handling#33424

Merged
ajivanyandev merged 2 commits intoDevExpress:26_1from
ajivanyandev:license/remove-dx1003-related-code
Apr 27, 2026
Merged

License: Remove expired trial handling#33424
ajivanyandev merged 2 commits intoDevExpress:26_1from
ajivanyandev:license/remove-dx1003-related-code

Conversation

@ajivanyandev
Copy link
Copy Markdown
Contributor

No description provided.

@ajivanyandev ajivanyandev self-assigned this Apr 27, 2026
Copilot AI review requested due to automatic review settings April 27, 2026 13:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes “expired trial” detection and messaging from DevExtreme’s license tooling and runtime warning output paths, aligning behavior toward treating these cases as generic license verification failures.

Changes:

  • Removed trialExpired warning/template from the devextreme-license CLI messages and output logic.
  • Removed trial-expired token-to-warning mapping from runtime license validation/warnings.
  • Removed expired-trial detection branch from the JS LCP parser used by the CLI conversion logic.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/devextreme/license/messages.js Drops trialExpired warning code/template text.
packages/devextreme/license/dx-lcx-2-lcp.js Removes expired-trial classification during LCP parsing.
packages/devextreme/license/devextreme-license.js Simplifies CLI warning output; no longer adds purchase line specifically for expired trial.
packages/devextreme/js/__internal/core/license/license_warnings.ts Removes the trial-expired warning rendering branch.
packages/devextreme/js/__internal/core/license/license_validation.ts Stops mapping trial-expired token to W0020 / trial-expired warning type.
Comments suppressed due to low confidence (3)

packages/devextreme/js/__internal/core/license/license_warnings.ts:112

  • With the 'trial-expired' switch case removed, logLicenseWarning no longer has explicit handling for the 'trial-expired' LicenseWarningType (still present in the type union). If any future call site passes 'trial-expired', the function will only log the purchase line and omit context. Either remove 'trial-expired' from LicenseWarningType or keep an explicit branch here to ensure consistent output.

    case 'no-devextreme-license':
      // Only the purchase line, no additional details
      break;
    default:

packages/devextreme/license/dx-lcx-2-lcp.js:224

  • After removing the trial-expired branch in parseLCP, this JS implementation no longer matches the TS validator (lcp_key_validator.ts still returns a 'trial-expired' token for expired trial-only keys). Please either remove the trial-expired classification in the TS parser/types/tests as well, or restore equivalent logic here so devextreme-license and runtime validation stay consistent.
        const maxVersionAllowed = findLatestDevExtremeVersion(products);

        if(!maxVersionAllowed) { 
            return { ...PRODUCT_KIND_ERROR, licenseId }; 
        }

packages/devextreme/license/dx-lcx-2-lcp.js:224

  • Removing the trial-expired check makes getMaxExpiration() unused in this file (only definition remains). If eslint/no-unused-vars is enabled for the license tool, this will fail lint; please delete getMaxExpiration (and any now-dead helpers) or reintroduce a caller.
        const maxVersionAllowed = findLatestDevExtremeVersion(products);

        if(!maxVersionAllowed) { 
            return { ...PRODUCT_KIND_ERROR, licenseId }; 
        }

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

packages/devextreme/license/dx-lcx-2-lcp.js:224

  • getMaxExpiration is now unused after removing the trial-expired branch. Since no-unused-vars is enforced in this package, this leftover helper will trigger lint errors—please remove it (and any now-dead constants/logic tied to it) from dx-lcx-2-lcp.js.
        const maxVersionAllowed = findLatestDevExtremeVersion(products);

        if(!maxVersionAllowed) { 
            return { ...PRODUCT_KIND_ERROR, licenseId }; 
        }

@ajivanyandev ajivanyandev merged commit 239438e into DevExpress:26_1 Apr 27, 2026
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants