DataGrid - AI Assistant: Implement GridCommands class by dmirgaev · Pull Request #33460 · DevExpress/DevExtreme

dmirgaev · 2026-04-29T16:19:16Z

No description provided.

Copilot

Pull request overview

This PR introduces the internal infrastructure for a DataGrid AI Assistant command system by adding a GridCommands utility (schema building, response validation, sequential command execution) plus initial scaffolding for an AIAssistantIntegrationController. It also updates dependencies and adds new localization keys for assistant error/abort messaging.

Changes:

Add GridCommands (+ spec doc) and supporting types for command schema generation (JSON Schema draft-07 via Zod) and command execution.
Add a new AIAssistantIntegrationController (currently with stubbed buildContext / buildResponseSchema).
Add Jest tests for GridCommands and update AI assistant integration controller test import; update deps (zod-to-json-schema) and add new message keys.

Reviewed changes

Copilot reviewed 37 out of 39 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Locks `zod-to-json-schema@3.24.6` and pins `zod` specifier for devextreme importer.
packages/devextreme/package.json	Adds `zod-to-json-schema` dependency; pins `zod` to an exact version.
packages/devextreme/js/localization/messages/ar.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/bg.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/ca.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/cs.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/da.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/de.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/el.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/en.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/es.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/fa.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/fi.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/fr.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/hu.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/it.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/ja.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/ko.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/lt.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/lv.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/nb.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/nl.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/pl.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/pt.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/ro.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/ru.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/sl.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/sv.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/tr.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/uk.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/vi.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/zh.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/localization/messages/zh-tw.json	Adds AI assistant error + execution-abort message keys.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/types.ts	Adds JSON schema type + message customization types for command execution results.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands_spec.md	Adds a detailed implementation specification for `GridCommands` and command set.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands.ts	Implements `GridCommands` (schema generation, validation, sequential execution, abort + message customization).
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_integration_controller.ts	Adds controller scaffold for sending AI requests and aborting them (context/schema currently stubbed).
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/grid_commands.test.ts	Adds Jest coverage for `GridCommands` behaviors (schema, validate, execute, abort, reentrancy, customization).
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_integration_controller.integration.test.ts	Updates test import path to the new controller file.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 38 out of 40 changed files in this pull request and generated 7 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 37 out of 39 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (2)

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts:95

GridCommands is instantiated with an empty command registry. With the current GridCommands.validate/executeCommands behavior this makes every AI-produced action unknown/invalid, so the assistant can never successfully validate/execute commands. Register the available grid commands here (e.g., from ./commands/*) or otherwise ensure the controller passes a non-empty, feature-appropriate command list.

  public init(): void {
    this.gridCommands = new GridCommands(this.component, []);
    this.messageStore = new ArrayStore<Message, string>({
      key: 'id',
    });
    this.aiAssistantIntegrationController = new AIAssistantIntegrationController(this.component);
    this.aiAssistantIntegrationController.init();

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts:95

processResponse calls this.gridCommands?.validate(response.actions), but GridCommands.validate currently expects an object with an actions array (it checks res.actions). This mismatch makes validation always fail at runtime. Align the API by either changing GridCommands.validate to accept an actions array, or by passing the full response shape from here.

  public init(): void {
    this.gridCommands = new GridCommands(this.component, []);
    this.messageStore = new ArrayStore<Message, string>({
      key: 'id',
    });
    this.aiAssistantIntegrationController = new AIAssistantIntegrationController(this.component);
    this.aiAssistantIntegrationController.init();

Copilot

Pull request overview

Copilot reviewed 40 out of 42 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 40 out of 42 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts:96

AIAssistantController constructs GridCommands with an empty command registry. With the new GridCommands.validate() implementation, any non-empty response.actions will be rejected as “unknown command”, making AI assistant execution fail even when the provider returns actions. The controller needs to pass the actual list of supported GridCommands (or delay validation/execution until commands are registered).

  public init(): void {
    this.gridCommands = new GridCommands(this.component, []);
    this.messageStore = new ArrayStore<Message, string>({
      key: 'id',
    });
    this.aiAssistantIntegrationController = new AIAssistantIntegrationController(this.component);
    this.aiAssistantIntegrationController.init();
  }

Copilot · 2026-04-30T15:18:56Z

+  public buildResponseSchema(): JsonSchema {
+    const branches = [...this.commands.values()].map((command) => {
+      const argsSchema = zodToJsonSchema(command.schema, { target: 'jsonSchema7' });
+
+      // Remove $schema from nested schemas since it's only necessary at root
+      delete argsSchema.$schema;
+
+      return {
+        type: 'object',
+        description: command.description,
+        required: ['name', 'args'],
+        additionalProperties: false,
+        properties: {
+          name: {
+            type: 'string',
+            enum: [command.name],
+          },
+          args: argsSchema,
+        },


buildResponseSchema() generates JSON Schema from command.schema, but validate() enforces command.schema.strict(). If a command schema is not strict, the LLM may produce extra properties that appear valid per the generated JSON Schema but will be rejected by validate(). Consider generating the schema from the same strict schema you validate against (or otherwise ensure both paths enforce the same additional-properties behavior).

anna-shakhova · 2026-05-05T13:50:16Z


  public init(): void {
-    this.gridCommands = new GridCommands(this.component);
+    this.gridCommands = new GridCommands(this.component, []);


please add todo to define default commands list when they are ready + it should support extension in ingerited classed

anna-shakhova · 2026-05-05T13:52:21Z

+  JsonSchema,
+} from './types';
+
+const DEFAULT_SUCCESS_MESSAGE = 'dxDataGrid-aiAssistantSuccessMessage';


lets move it to const.ts for consistency

anna-shakhova · 2026-05-05T13:55:35Z

+
+  private readonly commands: Map<string, GridCommand<Record<string, unknown>>>;
+
+  private _executing = false;


we do not use underscore for private properties and methods anymore - keyword is enough

anna-shakhova · 2026-05-05T13:57:11Z

-  constructor(private readonly gridInstance: InternalGrid) {
+  private readonly component: InternalGrid;
+
+  private readonly commands: Map<string, GridCommand<Record<string, unknown>>>;


please, add todo to specify type when we settle all names and schemas

anna-shakhova · 2026-05-05T13:58:16Z

+    this.commands = new Map();
+
+    for (const command of commands) {
+      if (this.commands.has(command.name)) {


should we handle it as error ot just overwrite the previous one?

anna-shakhova · 2026-05-05T14:02:22Z

+        return false;
+      }
+
+      if (!isDefined(action.args) || !isObject(action.args)) {


looks like we can combine if with prev condition without loosing readability

anna-shakhova · 2026-05-05T14:02:58Z

-      message: action.name,
-    })));
+  private async executeCommand(
+    command: GridCommand<Record<string, unknown>>,


please, add todo to specify type

anna-shakhova · 2026-05-05T14:07:18Z

+      const command = this.commands.get(name);
+
+      if (!command) {
+        this._executing = false;


looks like in current implementation we'll never hit this case - we cannot change commands list in runtime and already validated result, we can keep it for safety, but add comment, please

anna-shakhova · 2026-05-05T14:11:29Z

+    }
+  }
+
+  public async executeCommands(


in ai_assistant_controller we call this methods with commands only, add second arg in call, please
use private types while we not provided callback in public dts

Copilot

Pull request overview

Copilot reviewed 40 out of 42 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

dmirgaev self-assigned this Apr 29, 2026

Copilot AI review requested due to automatic review settings April 29, 2026 16:19

dmirgaev requested review from a team as code owners April 29, 2026 16:19

dmirgaev added skip-cache 26_1 labels Apr 29, 2026

Copilot started reviewing on behalf of dmirgaev April 29, 2026 16:20 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands.ts

Comment thread packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands.ts

dmirgaev force-pushed the 26_1__datagrid_commands branch from 40151ee to 530a7ff Compare April 29, 2026 17:24

Copilot AI review requested due to automatic review settings April 29, 2026 17:31

Copilot started reviewing on behalf of dmirgaev April 29, 2026 17:32 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 30, 2026 08:47

dmirgaev force-pushed the 26_1__datagrid_commands branch from c9fabe8 to 395f2ed Compare April 30, 2026 08:47

Copilot started reviewing on behalf of dmirgaev April 30, 2026 08:47 View session

arman-boyakhchyan previously approved these changes Apr 30, 2026

View reviewed changes

Copilot AI reviewed Apr 30, 2026

View reviewed changes

dmirgaev dismissed arman-boyakhchyan’s stale review via be9ede3 April 30, 2026 10:19

Copilot AI review requested due to automatic review settings April 30, 2026 10:50

Copilot started reviewing on behalf of dmirgaev April 30, 2026 10:51 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands.ts

Comment thread packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands.ts

Comment thread packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts

Copilot AI review requested due to automatic review settings April 30, 2026 15:12

dmirgaev force-pushed the 26_1__datagrid_commands branch from 83ae1dd to 80be63d Compare April 30, 2026 15:12

Copilot started reviewing on behalf of dmirgaev April 30, 2026 15:12 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

dmirgaev added skip-cache and removed skip-cache labels May 5, 2026

dmirgaev added 3 commits May 5, 2026 15:15

install zod and zon-to-json-schema packages

6b36b60

add necessary types for grid commands

ad82b0b

temporarily add grid_commands_spec.md to observe all the changes

07483c9

dmirgaev added 15 commits May 5, 2026 15:15

clarify JsonSchema type

5b455b8

fix naming

d1ee0a8

remove "m_" prefix from AIAssistantIntegrationController

67d8f66

GridCommands class draft

bbbc42d

add localized messages

88ba9db

added tests according to acceptance criteria

ca5bdb9

fix types after rebasing

3d01c02

fix after rebasing

d7010df

fix ai chat integration

0110696

remove temporarily added specification

b151d0b

fix qunit tests

d8346bc

fix a response validation

91e590f

fix type error and zod-to-json-schema import path

48fa34a

fix zod import path for qunit tests

570b7d4

fix import path and format for zod and zod-to-json-schema

ed1bee8

dmirgaev force-pushed the 26_1__datagrid_commands branch from 80be63d to ed1bee8 Compare May 5, 2026 11:17

anna-shakhova reviewed May 5, 2026

View reviewed changes

fix qunit meta

2e21afd

Copilot AI review requested due to automatic review settings May 5, 2026 14:34

Copilot started reviewing on behalf of anna-shakhova May 5, 2026 14:35 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

try zod stabs for qunit configuration

608c476


		private readonly commands: Map<string, GridCommand<Record<string, unknown>>>;

		private _executing = false;

Conversation

dmirgaev commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

anna-shakhova May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anna-shakhova May 5, 2026 •

edited

Loading