Replace gulp by nx-infra-plugin in devextreme-scss#33461
Draft
GoodDayForSurf wants to merge 12 commits intoDevExpress:26_1from
Draft
Replace gulp by nx-infra-plugin in devextreme-scss#33461GoodDayForSurf wants to merge 12 commits intoDevExpress:26_1from
GoodDayForSurf wants to merge 12 commits intoDevExpress:26_1from
Conversation
cd0bdfb to
026df10
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the devextreme-scss theme build pipeline from Gulp-based tasks to a dedicated Nx Infra Plugin executor, aiming to make SCSS theme compilation and asset copying fully Nx-driven and cacheable across the monorepo.
Changes:
- Removed
devextreme-scssGulp build implementation (gulpfile + style compiler + gulp data-uri) and related dependencies. - Added a new
devextreme-nx-infra-plugin:scss-buildexecutor that generates SCSS bundles and compiles/minifies CSS (with license header + charset handling). - Updated
devextreme, ThemeBuilder, and CI workflow wiring to use Nx targets for building themes.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Removes Gulp-related dependencies from the lockfile for devextreme-scss. |
| packages/nx-infra-plugin/src/executors/scss-build/schema.ts | Adds TypeScript schema for the new SCSS build executor options. |
| packages/nx-infra-plugin/src/executors/scss-build/schema.json | Adds JSON schema for executor configuration / validation. |
| packages/nx-infra-plugin/src/executors/scss-build/executor.ts | Implements SCSS bundle generation, compilation, postcss/autoprefixer, clean-css minification, watch mode, and asset copying logic. |
| packages/nx-infra-plugin/src/executors/scss-build/executor.e2e.spec.ts | Adds an E2E test validating output, license header, and minification profile behavior. |
| packages/nx-infra-plugin/executors.json | Registers the new scss-build executor in the plugin. |
| packages/devextreme/package.json | Switches build-themes script from Gulp to Nx-driven devextreme-scss targets. |
| packages/devextreme-themebuilder/src/modules/post-compiler.ts | Improves @charset + info header handling; introduces an optional mode to append the info header at the end. |
| packages/devextreme-themebuilder/src/modules/compile-manager.ts | Uses the new addInfoHeader(..., true) behavior for ThemeBuilder output. |
| packages/devextreme-scss/project.json | Replaces Gulp scripts/inputs with Nx targets: clean, build themes (all/ci), copy assets, and watch. |
| packages/devextreme-scss/package.json | Removes Gulp-related devDependencies and updates scripts to call Nx targets. |
| packages/devextreme-scss/gulpfile.js | Deleted (Gulp entrypoint no longer used). |
| packages/devextreme-scss/build/style-compiler.js | Deleted (legacy SCSS build pipeline). |
| packages/devextreme-scss/build/gulp-data-uri.js | Deleted (legacy data-uri implementation). |
| .github/workflows/themebuilder_tests.yml | Updates ThemeBuilder CI to build “etalon bundles” via Nx instead of Gulp. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.