License: Text fixes#33550
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DevExtreme licensing-related warning text/templates and adjusts unit tests to assert on warning codes rather than specific message text.
Changes:
- Updates license warning phrasing (including the “old DevExtreme key” version text format).
- Changes the “key verification failed” default template output to an empty string in two places.
- Updates
license_validationJest tests to look forW0021instead of a specific message substring.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/devextreme/license/messages.js |
Tweaks license CLI template strings (including “old key” text) and changes default verification-failure message to empty. |
packages/devextreme/js/__internal/core/license/license_warnings.ts |
Adjusts warning prefix text and changes default verification-failure message to empty. |
packages/devextreme/js/__internal/core/license/license_validation.test.ts |
Updates assertions to expect W0021 instead of a hard-coded message fragment. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
packages/devextreme/license/devextreme-license.js:190
- By removing the standalone
keyVerificationFailedline from this output, the tool no longer prints any explicit reason whengetLCPInfo()reports non-trial, non-incompatibleVersionwarnings (e.g., corrupted/invalid keys). This makes the warning harder to understand becauseDX1001/DX1000prefixes don’t indicate verification failure. Consider keeping a short failure description here (or making it type-specific) so users can distinguish “invalid/corrupted key” from other license states.
if(lcx && lcx.trimStart().startsWith('ewog')) {
logStderr(
prefixed(`${TEMPLATES.warningPrefix(1000)} ${TEMPLATES.purchaseLicense}`),
TEMPLATES.oldDevExtremeKey(currentVersion),
TEMPLATES.keyWasFound(source.type, source.path),
prefixed(`${TEMPLATES.warningPrefix(1001)} ${TEMPLATES.installationInstructions}`),
);
GoodDayForSurf
approved these changes
May 12, 2026
| const pushToLastGroup = (...items: string[]): void => { | ||
| const lastGroup = warnings[warnings.length - 1]; | ||
| const notEmptyItems = items.filter((item) => !!item); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.