Skip to content

License: Text fixes#33550

Merged
GoodDayForSurf merged 5 commits into
DevExpress:26_1from
ajivanyandev:license/fix-texts
May 12, 2026
Merged

License: Text fixes#33550
GoodDayForSurf merged 5 commits into
DevExpress:26_1from
ajivanyandev:license/fix-texts

Conversation

@ajivanyandev
Copy link
Copy Markdown
Contributor

No description provided.

@ajivanyandev ajivanyandev self-assigned this May 11, 2026
Copilot AI review requested due to automatic review settings May 11, 2026 21:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates DevExtreme licensing-related warning text/templates and adjusts unit tests to assert on warning codes rather than specific message text.

Changes:

  • Updates license warning phrasing (including the “old DevExtreme key” version text format).
  • Changes the “key verification failed” default template output to an empty string in two places.
  • Updates license_validation Jest tests to look for W0021 instead of a specific message substring.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/devextreme/license/messages.js Tweaks license CLI template strings (including “old key” text) and changes default verification-failure message to empty.
packages/devextreme/js/__internal/core/license/license_warnings.ts Adjusts warning prefix text and changes default verification-failure message to empty.
packages/devextreme/js/__internal/core/license/license_validation.test.ts Updates assertions to expect W0021 instead of a hard-coded message fragment.

Comment thread packages/devextreme/license/messages.js
Comment thread packages/devextreme/js/__internal/core/license/license_warnings.ts
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

packages/devextreme/license/devextreme-license.js:190

  • By removing the standalone keyVerificationFailed line from this output, the tool no longer prints any explicit reason when getLCPInfo() reports non-trial, non-incompatibleVersion warnings (e.g., corrupted/invalid keys). This makes the warning harder to understand because DX1001/DX1000 prefixes don’t indicate verification failure. Consider keeping a short failure description here (or making it type-specific) so users can distinguish “invalid/corrupted key” from other license states.
    if(lcx && lcx.trimStart().startsWith('ewog')) {
        logStderr(
            prefixed(`${TEMPLATES.warningPrefix(1000)} ${TEMPLATES.purchaseLicense}`),
            TEMPLATES.oldDevExtremeKey(currentVersion),
            TEMPLATES.keyWasFound(source.type, source.path),
            prefixed(`${TEMPLATES.warningPrefix(1001)} ${TEMPLATES.installationInstructions}`),
        );

Comment thread packages/devextreme/js/__internal/core/license/license_warnings.ts
Comment thread packages/devextreme/license/devextreme-license.js
Copilot AI review requested due to automatic review settings May 12, 2026 17:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

const pushToLastGroup = (...items: string[]): void => {
const lastGroup = warnings[warnings.length - 1];
const notEmptyItems = items.filter((item) => !!item);

@GoodDayForSurf GoodDayForSurf merged commit d7accf8 into DevExpress:26_1 May 12, 2026
110 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants