AI Assistant: Integration between AiIntegration, GridCommands, AiAssistant and AiChat by dmirgaev · Pull Request #33564 · DevExpress/DevExtreme

dmirgaev · 2026-05-12T23:07:30Z

No description provided.

actualize tests for AIAssistantIntegrationController implement buildContext method pass response schema to AI Integration from AI controller fix option types and add todos to move them to d.ts implement getCustomizedResponseTitle method add a command list to both controllers temporarily add the specification add getGridCommandList method to be able to override it in a simple way Replace CommandResults type with simple CommandResult[] and remove it from types as redundant

Copilot

Pull request overview

This PR wires the grid AI assistant end-to-end by connecting AIIntegration request execution to GridCommands (including response schema generation + grid context building) and then displaying the results in AIChat, with DataGrid-specific command/extra-context extensions.

Changes:

Replaces the CommandResults alias usage with CommandResult[] across AI chat/assistant plumbing.
Extends AIAssistantIntegrationController.sendRequest to accept a per-request responseSchema and an extraContext selector, and implements buildContext(...) to serialize current grid state.
Introduces a core command registry (commandsCore) and a DataGrid override controller that supplies DataGrid-specific commands and extra context options.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/devextreme/js/__internal/grids/grid_core/ai_chat/utils.ts	Updates command typing and command-error detection used for message status/icon rendering.
packages/devextreme/js/__internal/grids/grid_core/ai_chat/types.ts	Stops re-exporting `CommandResults`; keeps `CommandResult`.
packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.ts	Updates command list rendering to accept `CommandResult[]`.
packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.test.ts	Adjusts tests for the new command array typing.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/types.ts	Adds JSON schema/context-related types and updates AI message command typing.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands.ts	Minor cleanup of TODO comments; command execution/schema generation remains the same.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/index.ts	Adds a core list of built-in grid AI commands and exports `commandsCore`.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_integration_controller.ts	Adds `responseSchema` + `extraContext` inputs and implements grid/column context building.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts	Uses generated response schema/context, adds response title customization logic, and initializes default command list.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_integration_controller.integration.test.ts	Expands integration tests for schema passing, abort behavior, and context building.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/index.ts	Builds a DataGrid command set by extending core commands with grouping/summary.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/ai_assistant.ts	Switches DataGrid to use a DataGrid-specific AI assistant controller.
packages/devextreme/js/__internal/grids/data_grid/ai_assistant/ai_assistant_controller.ts	Adds DataGrid overrides for command list and extra context options.

Comments suppressed due to low confidence (3)

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts:92

The rejection message 'Default error message' is a placeholder and is user-visible through error.message. Replace it with a localized and actionable message (or reuse an existing localization key) to avoid shipping placeholder text.

    if (!response?.actions || !Array.isArray(response.actions) || !response.actions.length) {
      // TODO: need to localize default error message when there are no commands
      return Promise.reject(new Error('Default error message'));
    }

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts:97

The rejection message 'Received invalid commands' is hard-coded and not localized. Consider using a localized message (and include basic context like validation failure) since this string will be shown to end users.

    if (!this.gridCommands?.validate(response.actions)) {
      // TODO: need to localize error message on validation fail
      return Promise.reject(new Error('Received invalid commands'));
    }

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts:190

new Error('Grid commands not initialized') is user-visible via failAIMessage and is currently a hard-coded English internal detail. Replace with a localized, user-facing message (and/or ensure this situation cannot happen after init()).

      if (!responseSchema) {
        // TODO: Change error message
        const error = new Error('Grid commands not initialized');

        this.failAIMessage(aiMessage.id, error);
        this.setProcessing(false);
        reject(error);

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (3)

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/types.ts:118

GridContext.selection.selectedRowKeys is typed as (string | number)[], but grid selection keys can be any type (e.g., composite/object keys). This makes the context typing incorrect and forces unsafe casts elsewhere. Consider widening this to unknown[] (or Array<TKey>/any[]), matching grid option typings, to avoid losing type support for valid key shapes.

  search: {
    searchText: string;
  };
  selection: {
    selectedRowKeys: (string | number)[];
  };
}

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_integration_controller.ts:75

If onAIAssistantRequestCreating sets args.cancel = true, sendRequest returns without invoking any callback and without setting this.abort. Callers (e.g., AIAssistantController) currently set their own processing flag before calling sendRequest, so this path can leave the request promise pending indefinitely. Consider either notifying via callbacks (e.g., onError/onAbort) when cancelled, or returning a boolean indicating whether a request was actually started so the caller can cleanly resolve/reject and reset state.

    this.executeAction('onAIAssistantRequestCreating', args);

    if (args.cancel) {
      return;
    }

packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts:222

The // TODO: Change error message comments inside the .fail and onError handlers are misindented relative to the surrounding block, which is likely to trip formatting/lint rules and makes the nested callback harder to read. Please align these comments with the rest of the block indentation.

                resolve();
              })
              .fail((errorMessage) => {
              // TODO: Change error message
                const error = errorMessage instanceof Error
                  ? errorMessage
                  : new Error(String(errorMessage));

                this.failAIMessage(aiMessage.id, error);
                this.setProcessing(false);
                reject(error);
              });
          },
          onError: (error: Error): void => {
          // TODO: Change error message
            this.failAIMessage(aiMessage.id, error);
            this.setProcessing(false);

+  dataType: DataType | undefined;
+  visible: boolean;
+  sortOrder: SortOrder | undefined;
+  sortIndex: number | undefined;
+  filterValue: string | number | boolean | null | undefined;
+  fixed: boolean | undefined;
+  fixedPosition: FixedPosition | undefined;
+  width: number | string | undefined;


-    return {};
+  public buildContext(extraContext: GridExtraContextOption | null): GridContext {
+    const dataController = this.getController('data');
+    const selectedRowKeys = (this.option('selectedRowKeys') ?? []) as (string | number)[];


    const aiIntegration = this.getAIIntegration();
-    if (!aiIntegration) {
+
+    if (aiIntegration === null) {
+      errors.log('E1068');
      return;
    }


  private sendRequestToAICore(aiMessage: AIMessage): Promise<void> {
    this.setProcessing(true);

    return new Promise((resolve, reject) => {
-      this.aiAssistantIntegrationController?.sendRequest(aiMessage.prompt, {
-        onComplete: (response: ExecuteGridAssistantCommandResult): void => {
-          fromPromise(this.processResponse(response))
-            .done((commands: CommandResults) => {
-              this.completeAIMessage(aiMessage.id, commands);
-              this.setProcessing(false);
-              resolve();
-            })
-            .fail((errorMessage) => {
-              const error = errorMessage instanceof Error
-                ? errorMessage
-                : new Error(String(errorMessage));
-
-              this.failAIMessage(aiMessage.id, error);
-              this.setProcessing(false);
-              reject(error);
-            });
-        },
-        onError: (error: Error): void => {
-          this.failAIMessage(aiMessage.id, error);
-          this.setProcessing(false);
-          reject(error);
-        },
-        onAbort: (): void => {
-          const error = new Error(messageLocalization.format('dxDataGrid-aiAssistantAbortMessage'));
-
-          this.failAIMessage(aiMessage.id, error);
-          this.setProcessing(false);
-          reject(error);
+      const responseSchema = this.gridCommands?.buildResponseSchema();
+      const extraContext = this.getGridExtraContext();
+
+      if (!responseSchema) {
+        // TODO: Change error message
+        const error = new Error('Grid commands not initialized');
+
+        this.failAIMessage(aiMessage.id, error);
+        this.setProcessing(false);
+        reject(error);
+        return;
+      }
+
+      this.aiAssistantIntegrationController?.sendRequest(
+        aiMessage.prompt,
+        responseSchema,
+        extraContext,
+        {
+          onComplete: (response: ExecuteGridAssistantCommandResult): void => {
+            fromPromise(this.processResponse(response))
+              .done((commands: CommandResult[]) => {
+                const commandNames = this.getCommandNames(response.actions);
+
+                this.completeAIMessage(aiMessage.id, commands, commandNames);
+                this.setProcessing(false);


dmirgaev self-assigned this May 12, 2026

dmirgaev added the skip-cache label May 12, 2026

Copilot AI review requested due to automatic review settings May 12, 2026 23:07

dmirgaev requested a review from a team as a code owner May 12, 2026 23:07

dmirgaev added the 26_1 label May 12, 2026

Copilot started reviewing on behalf of dmirgaev May 12, 2026 23:08 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

dmirgaev removed the skip-cache label May 13, 2026

dmirgaev added 2 commits May 13, 2026 04:06

fix tests of AIAssistantController

a15e1ed

try to fix qunit tests

ac007ea

Copilot AI review requested due to automatic review settings May 13, 2026 00:40

Copilot started reviewing on behalf of dmirgaev May 13, 2026 00:41 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AI Assistant: Integration between AiIntegration, GridCommands, AiAssistant and AiChat#33564

AI Assistant: Integration between AiIntegration, GridCommands, AiAssistant and AiChat#33564
dmirgaev wants to merge 3 commits into
DevExpress:26_1from
dmirgaev:26_1__ai_assistant_integration

dmirgaev commented May 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dmirgaev commented May 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants