DataGrid - AI Assistant: update AI Chat regenerate button behavior and move some AIChat utility methods to AIAssistant utils#33571
Merged
Alyar666 merged 3 commits intoMay 13, 2026
Conversation
…d move some AIChat utility methods to AIAssistant utils
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the DataGrid AI Chat UI logic around message state rendering (icons, command list, regenerate button) and consolidates command-status helper utilities under the AI Assistant utilities module.
Changes:
- Simplified message icon selection to depend only on
message.status, and made command list rendering depend only on whethercommandsare present. - Changed regenerate button visibility to show only for failed messages that have no
commands. - Moved
hasCommandErrors/hasAbortedCommandshelpers fromai_chatutilities intoai_assistantutilities and added unit tests for them.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/utils.ts | Adjusts icon selection, command list rendering predicate, and regenerate button visibility rules. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/utils.test.ts | Updates unit tests to match the new ai_chat/utils behavior and removes tests for moved helpers. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.test.ts | Updates integration-style rendering tests to reflect the new icon/regenerate behavior. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/utils.ts | Adds/moves command-status helpers into AI Assistant utilities and removes dependency on ai_chat/utils. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/utils.test.ts | Adds unit tests for the moved command-status helpers. |
dmirgaev
requested changes
May 13, 2026
dmirgaev
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.