Skip to content

Grid AI Assistant: dts leftovers#33577

Open
anna-shakhova wants to merge 9 commits into
DevExpress:26_1from
anna-shakhova:26_1__ai_assistant_dts_leftovers
Open

Grid AI Assistant: dts leftovers#33577
anna-shakhova wants to merge 9 commits into
DevExpress:26_1from
anna-shakhova:26_1__ai_assistant_dts_leftovers

Conversation

@anna-shakhova
Copy link
Copy Markdown
Contributor

@anna-shakhova anna-shakhova commented May 14, 2026

add customizeResponseText, customizeResponseTitle to dts

@anna-shakhova anna-shakhova self-assigned this May 14, 2026
@github-actions github-actions Bot added the .d.ts label May 14, 2026
Comment thread packages/devextreme/js/common/grids.d.ts Outdated
@anna-shakhova anna-shakhova force-pushed the 26_1__ai_assistant_dts_leftovers branch from fbc0248 to e3e6db7 Compare May 14, 2026 12:50
@anna-shakhova anna-shakhova force-pushed the 26_1__ai_assistant_dts_leftovers branch from d4a0cc0 to adaf7d3 Compare May 15, 2026 11:59
@anna-shakhova anna-shakhova changed the title Grid AI Assistant: add customizeResponseText, `customizeResponseTit… Grid AI Assistant: dts leftovers May 15, 2026
@anna-shakhova anna-shakhova marked this pull request as ready for review May 15, 2026 12:28
@anna-shakhova anna-shakhova requested a review from a team as a code owner May 15, 2026 12:28
Copilot AI review requested due to automatic review settings May 15, 2026 12:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds missing AI Assistant response customization typings for grids and propagates the related types/options through DataGrid, TreeList, and framework wrappers.

Changes:

  • Adds customizeResponseText / customizeResponseTitle and command-related types to grid declarations.
  • Adds DataGrid-specific AI assistant command typings and exposes aiAssistant on DataGrid options.
  • Updates internal AI assistant callback handling and wrapper-generated Angular/React/Vue declarations.

Reviewed changes

Copilot reviewed 22 out of 28 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
packages/devextreme/ts/dx.all.d.ts Updates bundled declaration output for AI assistant/grid command types.
packages/devextreme/js/ui/tree_list.d.ts Re-exports new TreeList/common AI assistant types.
packages/devextreme/js/ui/tree_list_types.d.ts Mirrors TreeList type re-exports.
packages/devextreme/js/ui/data_grid.d.ts Adds DataGrid-specific AI assistant command types and option typing.
packages/devextreme/js/ui/data_grid_types.d.ts Re-exports DataGrid-specific AI assistant types.
packages/devextreme/js/common/grids.d.ts Defines shared AI assistant command/status/filter/key types.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/utils.ts Switches message status helper to public response status literals.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/types.ts Derives response customization callback type from public declarations.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands.ts Passes command object into customizeResponseText.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/utils.ts Reuses public composite key type.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts Uses public response/command-name typings for title customization.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/__tests__/utils.test.ts Updates status expectations to string literals.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/__tests__/grid_commands.test.ts Updates customization callback expectations to command object shape.
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/__tests__/ai_assistant_integration_controller.integration.test.ts Adjusts test casting for DataGrid properties.
packages/devextreme-vue/src/tree-list.ts Adds Vue TreeList nested AI assistant props.
packages/devextreme-vue/src/data-grid.ts Adds Vue DataGrid nested AI assistant props.
packages/devextreme-vue/src/common/index.ts Exposes new common grid AI assistant types in Vue namespace.
packages/devextreme-vue/src/common/grids.ts Re-exports new common grid AI assistant types for Vue.
packages/devextreme-react/src/tree-list.ts Adds React TreeList nested AI assistant props.
packages/devextreme-react/src/data-grid.ts Adds React DataGrid nested AI assistant props.
packages/devextreme-react/src/common/index.ts Exposes new common grid AI assistant types in React namespace.
packages/devextreme-react/src/common/grids.ts Re-exports new common grid AI assistant types for React.
packages/devextreme-metadata/make-angular-metadata.ts Updates Angular metadata mutations for AI assistant handling.
packages/devextreme-angular/src/ui/tree-list/nested/ai-assistant.ts Adds Angular TreeList nested AI assistant inputs.
packages/devextreme-angular/src/ui/data-grid/nested/ai-assistant.ts Adds Angular DataGrid nested AI assistant inputs.
packages/devextreme-angular/src/ui/data-grid/index.ts Adds Angular DataGrid top-level aiAssistant input.
packages/devextreme-angular/src/common/index.ts Exposes new common grid AI assistant types in Angular namespace.
packages/devextreme-angular/src/common/grids/index.ts Re-exports new common grid AI assistant types for Angular.
Comments suppressed due to low confidence (2)

packages/devextreme-angular/src/ui/data-grid/index.ts:355

  • The new top-level Angular input is typed as the common grid AIAssistant, but dxDataGrid now declares a DataGrid-specific AIAssistant that includes extra commands. Using the common type here drops DataGrid-only command names from customizeResponseText/customizeResponseTitle for Angular consumers.
    @Input()
    get aiAssistant(): AIAssistant {
        return this._getOption('aiAssistant');
    }
    set aiAssistant(value: AIAssistant) {

packages/devextreme-angular/src/ui/data-grid/nested/ai-assistant.ts:65

  • The DataGrid nested option uses Array<string> for command names even though the widget has a specific command-name union including DataGrid-only commands. This loses contextual typing and can reject callbacks typed against the DataGrid command-name type.
    get customizeResponseTitle(): ((status: ResponseStatus, commandNames: Array<string>) => string) {
        return this._getOption('customizeResponseTitle');
    }
    set customizeResponseTitle(value: ((status: ResponseStatus, commandNames: Array<string>) => string)) {
        this._setOption('customizeResponseTitle', value);

Comment thread packages/devextreme-react/src/data-grid.ts
Comment thread packages/devextreme-vue/src/data-grid.ts
Comment thread packages/devextreme-angular/src/ui/data-grid/nested/ai-assistant.ts
Comment thread packages/devextreme-metadata/make-angular-metadata.ts Outdated
Comment thread packages/devextreme-react/src/tree-list.ts
Comment thread packages/devextreme-vue/src/tree-list.ts
Comment thread packages/devextreme-angular/src/ui/tree-list/nested/ai-assistant.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants