Grid AI Assistant: dts leftovers#33577
Open
anna-shakhova wants to merge 9 commits into
Open
Conversation
anna-shakhova
commented
May 14, 2026
fbc0248 to
e3e6db7
Compare
d4a0cc0 to
adaf7d3
Compare
customizeResponseText, `customizeResponseTit…
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing AI Assistant response customization typings for grids and propagates the related types/options through DataGrid, TreeList, and framework wrappers.
Changes:
- Adds
customizeResponseText/customizeResponseTitleand command-related types to grid declarations. - Adds DataGrid-specific AI assistant command typings and exposes
aiAssistanton DataGrid options. - Updates internal AI assistant callback handling and wrapper-generated Angular/React/Vue declarations.
Reviewed changes
Copilot reviewed 22 out of 28 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/ts/dx.all.d.ts |
Updates bundled declaration output for AI assistant/grid command types. |
packages/devextreme/js/ui/tree_list.d.ts |
Re-exports new TreeList/common AI assistant types. |
packages/devextreme/js/ui/tree_list_types.d.ts |
Mirrors TreeList type re-exports. |
packages/devextreme/js/ui/data_grid.d.ts |
Adds DataGrid-specific AI assistant command types and option typing. |
packages/devextreme/js/ui/data_grid_types.d.ts |
Re-exports DataGrid-specific AI assistant types. |
packages/devextreme/js/common/grids.d.ts |
Defines shared AI assistant command/status/filter/key types. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/utils.ts |
Switches message status helper to public response status literals. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/types.ts |
Derives response customization callback type from public declarations. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/grid_commands.ts |
Passes command object into customizeResponseText. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/utils.ts |
Reuses public composite key type. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts |
Uses public response/command-name typings for title customization. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/__tests__/utils.test.ts |
Updates status expectations to string literals. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/__tests__/grid_commands.test.ts |
Updates customization callback expectations to command object shape. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/__tests__/ai_assistant_integration_controller.integration.test.ts |
Adjusts test casting for DataGrid properties. |
packages/devextreme-vue/src/tree-list.ts |
Adds Vue TreeList nested AI assistant props. |
packages/devextreme-vue/src/data-grid.ts |
Adds Vue DataGrid nested AI assistant props. |
packages/devextreme-vue/src/common/index.ts |
Exposes new common grid AI assistant types in Vue namespace. |
packages/devextreme-vue/src/common/grids.ts |
Re-exports new common grid AI assistant types for Vue. |
packages/devextreme-react/src/tree-list.ts |
Adds React TreeList nested AI assistant props. |
packages/devextreme-react/src/data-grid.ts |
Adds React DataGrid nested AI assistant props. |
packages/devextreme-react/src/common/index.ts |
Exposes new common grid AI assistant types in React namespace. |
packages/devextreme-react/src/common/grids.ts |
Re-exports new common grid AI assistant types for React. |
packages/devextreme-metadata/make-angular-metadata.ts |
Updates Angular metadata mutations for AI assistant handling. |
packages/devextreme-angular/src/ui/tree-list/nested/ai-assistant.ts |
Adds Angular TreeList nested AI assistant inputs. |
packages/devextreme-angular/src/ui/data-grid/nested/ai-assistant.ts |
Adds Angular DataGrid nested AI assistant inputs. |
packages/devextreme-angular/src/ui/data-grid/index.ts |
Adds Angular DataGrid top-level aiAssistant input. |
packages/devextreme-angular/src/common/index.ts |
Exposes new common grid AI assistant types in Angular namespace. |
packages/devextreme-angular/src/common/grids/index.ts |
Re-exports new common grid AI assistant types for Angular. |
Comments suppressed due to low confidence (2)
packages/devextreme-angular/src/ui/data-grid/index.ts:355
- The new top-level Angular input is typed as the common grid
AIAssistant, butdxDataGridnow declares a DataGrid-specificAIAssistantthat includes extra commands. Using the common type here drops DataGrid-only command names fromcustomizeResponseText/customizeResponseTitlefor Angular consumers.
@Input()
get aiAssistant(): AIAssistant {
return this._getOption('aiAssistant');
}
set aiAssistant(value: AIAssistant) {
packages/devextreme-angular/src/ui/data-grid/nested/ai-assistant.ts:65
- The DataGrid nested option uses
Array<string>for command names even though the widget has a specific command-name union including DataGrid-only commands. This loses contextual typing and can reject callbacks typed against the DataGrid command-name type.
get customizeResponseTitle(): ((status: ResponseStatus, commandNames: Array<string>) => string) {
return this._getOption('customizeResponseTitle');
}
set customizeResponseTitle(value: ((status: ResponseStatus, commandNames: Array<string>) => string)) {
this._setOption('customizeResponseTitle', value);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
customizeResponseText,customizeResponseTitleto dts