Skip to content

T1328375 - Web Dashboard: "Uncaught TypeError: Cannot read properties of null (reading 'hide')" error is thrown on attempt to scroll above the Bar column#33686

Merged
dmlvr merged 2 commits into
DevExpress:26_1from
dmlvr:T1328375_26_1
May 25, 2026
Merged

Conversation

@dmlvr

@dmlvr dmlvr commented May 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@dmlvr dmlvr self-assigned this May 22, 2026
Copilot AI review requested due to automatic review settings May 22, 2026 16:42
@dmlvr dmlvr requested a review from a team as a code owner May 22, 2026 16:42
@dmlvr dmlvr added the 26_1 label May 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a sparklines/bullet tooltip lifecycle issue where calling tooltip hide logic after tooltip disposal could throw (Cannot read properties of null (reading 'hide')). This aligns tooltip state tracking with tooltip disposal in the internal sparkline implementation and adds a regression test to prevent reintroduction.

Changes:

  • Reset _tooltipShown to false when the tooltip instance is disposed in BaseSparkline.
  • Add a QUnit regression test ensuring _hideTooltip() doesn’t throw after dispose() on dxBullet.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/testing/tests/DevExpress.viz.sparklines/baseSparklineTooltipEvents.tests.js Adds a regression test covering calling _hideTooltip() after disposal and asserting no runtime errors.
packages/devextreme/js/__internal/viz/sparklines/base_sparkline.ts Clears _tooltipShown during tooltip disposal to prevent calling hide() on a disposed/null tooltip.

…seSparklineTooltipEvents.tests.js

Co-authored-by: Andrei Kharitonov <andrei.kharitonov@devexpress.com>
Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 22, 2026 17:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants