DateBox: Fix floating label overlapping date format hint for native picker (T1328901)#33707
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an issue in the DateBox native picker where the floating label could overlap the browser-provided date format hint when the editor value is null (T1328901).
Changes:
- Added a DateBox override to keep the editor from being treated as “empty” when
pickerType: 'native'. - Added a QUnit regression test to ensure the
dx-texteditor-emptyclass is not applied for native pickers withnullvalue and floating labels.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js | Adds a regression test asserting dx-texteditor-empty is not applied for native picker + null value with floating label. |
| packages/devextreme/js/__internal/ui/date_box/date_box.base.ts | Overrides _toggleEmptinessEventHandler to force non-empty state for native picker types, preventing label/format-hint overlap. |
marker-dao
approved these changes
May 25, 2026
vorobey
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.