Skip to content

DateBox: Fix floating label overlapping date format hint for native picker (T1328901) #33707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r-farkhutdinov merged 1 commit into from
May 26, 2026
+31 −0
Merged

DateBox: Fix floating label overlapping date format hint for native picker (T1328901) #33707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/devextreme/js/__internal/ui/date_box/date_box.base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,16 @@ class DateBox extends DropDownEditor<DateBoxBaseProperties> {
return super._isClearButtonVisible() && !this._isNativeType();
}

_toggleEmptinessEventHandler(): void {
if (this._isNativeType()) {
this._toggleEmptiness(false);

return;
}

super._toggleEmptinessEventHandler();
}

_renderValue(): DeferredObj<unknown> {
const value = this.getDateOption('value');

Expand Down
21 changes: 21 additions & 0 deletions packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ const CANCEL_BUTTON_SELECTOR = '.dx-popup-cancel.dx-button';
const TODAY_BUTTON_SELECTOR = `.${TODAY_BUTTON_CLASS}.${BUTTON_CLASS}`;
const BUTTON_SELECTOR = '.dx-button';
const TEXTBOX_SELECTOR = '.dx-textbox';
const TEXTEDITOR_EMPTY_INPUT_CLASS = 'dx-texteditor-empty';


const widgetName = 'dxDateBox';
const { module: testModule, test } = QUnit;
Expand Down Expand Up @@ -3059,6 +3061,25 @@ testModule('native picker', function() {
}
});
});

test('empty class should not be attached for native picker with null value (T1328901)', function(assert) {
const $dateBox = $('#dateBox').dxDateBox({
pickerType: 'native',
type: 'date',
value: null,
labelMode: 'floating',
label: 'Label',
});
const dateBox = $dateBox.dxDateBox('instance');
Comment thread
r-farkhutdinov marked this conversation as resolved.

assert.strictEqual($dateBox.hasClass(TEXTEDITOR_EMPTY_INPUT_CLASS), false,
'empty class is not attached so floating label does not overlap with browser-rendered date format hint');

dateBox.option('value', new Date());

assert.strictEqual($dateBox.hasClass(TEXTEDITOR_EMPTY_INPUT_CLASS), false,
'empty class remains absent after value is set');
});
});

QUnit.module('valueChanged handler should receive correct event', {
Expand Down
Loading