DataGrid - AI Assistant: Fix infinite confirm dialog loop when closing popup during request#33708
Merged
Alyar666 merged 1 commit intoMay 26, 2026
Conversation
…g popup during request
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an issue in the DataGrid AI Assistant popup where confirming “close while request is processing” could re-trigger onHiding and repeatedly show the confirm dialog (infinite loop), by allowing the post-confirm hide() call to proceed without re-entering the confirm logic.
Changes:
- Added an
isHidingAfterConfirmguard to preventonHidingfrom showing the confirm dialog again after the user already confirmed. - Added a unit test that simulates
hide()triggeringonHidingagain while still “processing”, ensuring the confirm dialog is not reopened.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts | Adds a one-shot guard to avoid re-opening the confirm dialog during the confirmed hide flow. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view.test.ts | Adds coverage to ensure onHiding doesn’t re-show the confirm dialog when hide() is called after user confirmation. |
anna-shakhova
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.