GridCore: fix focus anchor when leave 1st cell with Shift+Tab (T1329750)#34107
Merged
anna-shakhova merged 1 commit intoJun 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a DataGrid keyboard-navigation edge case in GridCore where native Shift+Tab from the first editable cell could lose a stable focus “anchor”, leading to incorrect focus transition (e.g., not landing on the last header cell).
Changes:
- Ensure the focused data cell is explicitly focused (with
preventScroll) before disposing the cell editor during native Tab-out handling in cell/batch edit modes. - Add a TestCafe E2E regression test covering Shift+Tab from the first editable cell → last header cell behavior for Cell/Batch editing modes (T1329750).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts | Focus the cell before closing/disposal of the editor during native Tab-out to stabilize the browser’s Shift+Tab anchor. |
| e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/keyboardNavigation.functional.ts | Adds an E2E regression test validating Shift+Tab focus moves from the first editable cell to the last header cell in Cell/Batch modes. |
anna-shakhova
force-pushed
the
26_1__T1329750_focus_cell
branch
2 times, most recently
from
df6d989 to
929212f
Compare
anna-shakhova
changed the title
Alyar666
approved these changes
Jun 24, 2026
anna-shakhova
force-pushed
the
26_1__T1329750_focus_cell
branch
from
929212f to
7d1ad69
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.