PivotGrid A11y and KBN - Scrollable region must have keyboard access (axe issue) (KBN)#34235
Merged
bit-byte0 merged 3 commits intoJul 9, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves PivotGrid accessibility by ensuring the scrollable data area can be reached via keyboard navigation (addressing an axe “scrollable region must have keyboard access” issue), and adds coverage to prevent regressions.
Changes:
- Makes the first PivotGrid data-area cell focusable after render to provide a keyboard entry point into the scrollable region.
- Updates existing QUnit markup expectations to assert the new focusability behavior.
- Adds a Jest unit test covering initial render, re-render, and empty-data scenarios for the DataArea focusability behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.markup.tests.js | Updates markup test to assert the first data cell is tabbable (tabindex="0") for keyboard access. |
| packages/devextreme/js/__internal/grids/pivot_grid/data_area/m_data_area.ts | Sets tabindex on the first data cell after render via shared accessibility helper. |
| packages/devextreme/js/__internal/grids/pivot_grid/data_area/m_data_area.test.ts | Adds Jest coverage ensuring only the first data cell becomes focusable and remains so after re-render. |
This was referenced Jul 8, 2026
Merged
sjbur
approved these changes
Jul 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixed the axe accessibility error "Scrollable region must have keyboard access" in PivotGrid. The scrollable data area had nothing focusable inside, so keyboard users could not reach or scroll it
How
The first cell of the data area now gets
tabindex="0"(set in m_data_area.ts via the sharedsetTabIndexutility), so the Tab key can move focus into the scrollable region. The scroll containers themselves stay non-focusable, so screen readers keep announcing meaningful content instead of an unnamed scrollable element