Skip to content

Commit d31c61d

Browse files
Fix react lint (T1193601) (#852)
* Fix react lint (T1193601) * Change deps value
1 parent f4dca98 commit d31c61d

5 files changed

Lines changed: 10 additions & 8 deletions

File tree

packages/devextreme-cli/src/templates/react/application/src/components/user-panel/UserPanel.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useMemo } from 'react';
1+
import React, { useMemo, useCallback } from 'react';
22
import { useNavigate } from "react-router-dom";
33
import ContextMenu, { Position } from 'devextreme-react/context-menu';
44
import List from 'devextreme-react/list';
@@ -10,9 +10,9 @@ export default function UserPanel({ menuMode }<%=#isTypeScript%>: UserPanelProps
1010
const { user, signOut } = useAuth();
1111
const navigate = useNavigate();
1212

13-
function navigateToProfile() {
13+
const navigateToProfile = useCallback(() => {
1414
navigate("/profile");
15-
}
15+
}, [navigate]);
1616
const menuItems = useMemo(() => ([
1717
{
1818
text: 'Profile',
@@ -24,7 +24,7 @@ export default function UserPanel({ menuMode }<%=#isTypeScript%>: UserPanelProps
2424
icon: 'runner',
2525
onClick: signOut
2626
}
27-
]), [signOut]);
27+
]), [navigateToProfile, signOut]);
2828
return (
2929
<div className={'user-panel'}>
3030
<div className={'user-info'}>

packages/devextreme-cli/src/templates/react/application/src/contexts/navigation.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ function withNavigationWatcher(Component<%=#isTypeScript%>: React.ElementType<%=
2121

2222
useEffect(() => {
2323
setNavigationData<%=#isTypeScript%>!<%=/isTypeScript%>({ currentPath: path });
24-
}, [path, setNavigationData]);
24+
}, [setNavigationData]);
2525

2626
return <Component {...props} />;
2727
}

packages/devextreme-cli/src/templates/react/application/src/layouts/side-nav-inner-toolbar/side-nav-inner-toolbar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export default function SideNavInnerToolbar({ title, children }<%=#isTypeScript%
4646
: prevMenuStatus
4747
);
4848
return menuStatus === MenuStatus.Closed ? true : false;
49-
}, [isLarge]);
49+
}, [isLarge, menuStatus]);
5050

5151
const onNavigationChanged = useCallback(({ itemData, event, node }<%=#isTypeScript%>: TreeViewTypes.ItemClickEvent<%=/isTypeScript%>) => {
5252
if (menuStatus === MenuStatus.Closed || !itemData<%=#isTypeScript%>?<%=/isTypeScript%>.path || node<%=#isTypeScript%>?<%=/isTypeScript%>.selected) {

packages/devextreme-cli/src/templates/react/application/src/layouts/side-nav-outer-toolbar/side-nav-outer-toolbar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export default function SideNavOuterToolbar({ title, children }<%=#isTypeScript%
4444
: prevMenuStatus
4545
);
4646
return menuStatus === MenuStatus.Closed ? true : false;
47-
}, [isLarge]);
47+
}, [isLarge, menuStatus]);
4848

4949
const onNavigationChanged = useCallback(({ itemData, event, node }<%=#isTypeScript%>: TreeViewTypes.ItemClickEvent<%=/isTypeScript%>) => {
5050
if (menuStatus === MenuStatus.Closed || !itemData<%=#isTypeScript%>?<%=/isTypeScript%>.path || node<%=#isTypeScript%>?<%=/isTypeScript%>.selected) {
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
export default {
1+
const userInfo = {
22
email: 'sandra@example.com',
33
avatarUrl: 'https://js.devexpress.com/Demos/WidgetsGallery/JSDemos/images/employees/06.png'
44
}
5+
6+
export default userInfo;

0 commit comments

Comments
 (0)