fix: roulette

- /roulette no establecia el cooldown correctamente en algunas ocasiones
- los boosts dados por la Ruleta ya no verificarán si sobre-benefician al usuario

Author: DevJeffreyG

src/commands/fun/roulette.js

@@ -47,10 +47,12 @@ command.execute = async (interaction, models, params, client) => {
         await interaction.deleteReply()
         return await interaction.followUp({ flags: [MessageFlags.Ephemeral], content: "No me la vas a creer, pero no pude encontrar un item indicado para ti :(" })
     }
-    
+
     const item = new RouletteItem(interaction, randomItem).build(user, doc);
 
-    await item.use()
+    let afterUse = await item.use();
+
+    await afterUse.user.save();
 
     if (notSelected.size > 0) {
         await interaction.followUp({
@@ -65,7 +67,7 @@ command.execute = async (interaction, models, params, client) => {
 
         let start = new Date()
         let i = 0;
-        if(query.length === 0) return -1;
+        if (query.length === 0) return -1;
 
         while (!returnable) {
             i++
@@ -78,11 +80,7 @@ command.execute = async (interaction, models, params, client) => {
 
             //console.log(selected ? "🟢 Selected" : "🔴 Negative");
 
-            let benefit = false;
-
-            if (q.extra?.special === ItemObjetives.Boost) benefit = await WillBenefit(interaction.member, [q.extra.boostobj, BoostObjetives.All])
-
-            returnable = selected && !benefit ? q : null
+            returnable = selected ? q : null
 
             if (moment(date).diff(start, "second") >= 3) returnable = benefit ? -1 : q;
         }

src/utils/RouletteItem.js

@@ -105,7 +105,6 @@ class RouletteItem {
     }
 
     async use() {
-        let save = true;
         let response = null;
         //let value = this.#valueWork();
 
@@ -114,8 +113,6 @@ class RouletteItem {
         console.log("🟢 Números:", this.numbers)
         console.log("🟢 No-Números:", this.nonumbers)
 
-        await this.user.addCount("roulette", 1, false);
-
         switch (this.target.constructor) {
             case GuildMemberRoleManager:
                 if (this.nonumbers === '-') this.target.remove(this.numbers)
@@ -135,9 +132,8 @@ class RouletteItem {
                 } else if (this.nonumbers === '+') {
                     if (temproles) {
                         response = this.addedTemp;
-                        save = false
 
-                        await LimitedTime(this.interaction.member, null, ms(this.item.extra.duration), {}, this.item.extra.boosttype, this.item.extra.boostobj, this.item.extra.boostvalue);
+                        this.user = await LimitedTime(this.interaction.member, null, ms(this.item.extra.duration), {}, this.item.extra.boosttype, this.item.extra.boostobj, this.item.extra.boostvalue, false, this.user);
                     } else
                         this.target.push(this.numbers)
                 }
@@ -187,9 +183,8 @@ class RouletteItem {
                 response = this.success;
                 break;
         }
-
+        
         if (!response) response = this.success;
-        if (save) await this.user.save().catch(e => console.log(e));
 
         await this.interaction.editReply({ embeds: [response] })
         return this;

src/utils/functions.js

@@ -1038,12 +1038,13 @@ const PetWork = async function (guild) {
  * @param {any} activation_info La del item de la tienda
  * @param {Number} [specialType=false] The special type of this temporary role.
  * @param {Number} [specialObjective=false] The objetive for this special type of temporary role.
- * @param {number} [specialValue=false] The value for the objetive of this special temporary role.
+ * @param {number} [specialValue=false] The value for the objetive of this special temporary role. 
+ * @param {boolean} [save=true] Whether save the user after adding the temporary role or not.
  * @returns Mongoose User document
  */
-const LimitedTime = async function (victimMember, roleID = 0, duration, activation_info, specialType = null, specialObjective = null, specialValue = null) {
+const LimitedTime = async function (victimMember, roleID = 0, duration, activation_info, specialType = null, specialObjective = null, specialValue = null, save = true, userDoc = null) {
   let role = victimMember.guild.roles.cache.find(x => x.id === roleID);
-  let user = await Users.getWork({ user_id: victimMember.id, guild_id: victimMember.guild.id });
+  let user = userDoc ?? await Users.getWork({ user_id: victimMember.id, guild_id: victimMember.guild.id });
 
   let active_until = moment().add(duration === Infinity ? ms("999y") : duration, "ms").startOf("minute").toDate();
 
@@ -1066,7 +1067,7 @@ const LimitedTime = async function (victimMember, roleID = 0, duration, activati
   }
 
   user.data.temp_roles.push(toPush);
-  await user.save();
+  if (save) await user.save();
 
   // timeout, por si pasa el tiempo antes de que el bot pueda reiniciarse
   TimeoutIf(duration, async function () {